create-figma-plugin icon indicating copy to clipboard operation
create-figma-plugin copied to clipboard

Published 20 hours ago • verified publisher icon yuanqing

Fix Windows

Open TheUltDev opened this issue 1 year ago • 2 comments

Fixes #205.

This change appends the file:// protocol to windows paths to the error below (technically we let pathToFileURL from node:url do the work)

ESBuild: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader.
On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

TheUltDev avatar Jan 01 '24 23:01 TheUltDev

@yuanqing this is ready (no more commits expected)

Verified on a Windows machine with all overrides present.

TheUltDev avatar Jan 02 '24 00:01 TheUltDev

I need this, please

XmlmXmlmX avatar Jan 19 '24 12:01 XmlmXmlmX

@yuanqing Can we please get this PR merged? It's a major blocker in upgrading to the newest version for windows users

JanJankowskiEvinced avatar Mar 28 '24 06:03 JanJankowskiEvinced

@TheUltDev – Thanks for this! I’ve merged but made a small change to move the logic into importFresh; see https://github.com/yuanqing/create-figma-plugin/commit/7d37de769b1b87ce72b0216a55cf6953593b06aa. The fix will be included in v3.2.0

yuanqing avatar Apr 04 '24 11:04 yuanqing