dbt-artifacts-parser icon indicating copy to clipboard operation
dbt-artifacts-parser copied to clipboard

Support pydantic 2

Open yu-iskw opened this issue 2 years ago • 6 comments

As of this writing, we support only pydantic v1. It would be good to support pydantic v2 as well.

yu-iskw avatar Nov 06 '23 01:11 yu-iskw

link

  • https://github.com/yu-iskw/dbt-artifacts-parser/pull/66

yu-iskw avatar Nov 22 '23 05:11 yu-iskw

@OnkarVO7 Let me ask you a question about pydantic. Do you have any plan to use pydantic 2 in OpenMetadata? Otherwise, do any other connectors still need pydantic 1 due to the dependency?

As you may know, pydantic 2 was released. I am wondering how we can support both major versions of pydantics. Or I just want to know we can migrate to pydantic 2 without deep consideration. I haven't investigated if pydantic 2 is fully compatible to pydantic 1 or not. I'm sure OpenMetadata is the largest project which uses the python package.

I left a little bit in my mind at the following link: https://github.com/yu-iskw/dbt-artifacts-parser/pull/66#issuecomment-1822097260

yu-iskw avatar Nov 22 '23 05:11 yu-iskw

@yu-iskw we do plan on migrating to pydantic v2 in the near future, probably in the next couple of releases. Do let us know your plans on supporting this we'll also plan accordingly

OnkarVO7 avatar Nov 22 '23 06:11 OnkarVO7

@OnkarVO7 Thank you for sharing. I don't have a clear plan. But, I would love to definitely support pydantic 2 before the migration on the OpenMetadata side. I will make a list of potential approaches to satisfy requirements I am thinking.

yu-iskw avatar Nov 22 '23 14:11 yu-iskw

Besides, I've opened a discussion to get advice from the pydantic community.

https://github.com/pydantic/pydantic/discussions/8203

yu-iskw avatar Nov 22 '23 15:11 yu-iskw

Hellow @yu-iskw - lack of Pydantic v2 support blocks some of our users from upgrading to latest line of Airflow 2.8. Is there anything we can do to help with the migration? Pydantic v2 is now used by pretty much every other dependency we use (and we have 670+ of them altogether). so it would be cool if Pydantic v2 is also supported by dbt-artifact-parser.

Do you have a clearer plan by now currently ?

potiuk avatar Jan 26 '24 14:01 potiuk

Migrate it to pydantic 2

https://github.com/yu-iskw/dbt-artifacts-parser/pull/78

yu-iskw avatar May 22 '24 02:05 yu-iskw