oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Rewrite fortios model

Open robertcheramy opened this issue 1 month ago • 0 comments

Is your feature request related to a problem? Please describe. I added diagnose hardware deviceinfo psu and get system interface transceiver to the FortiOS model in a monkey patch. The handling of cmd :all is not working properly, and sending all the commands in post do makes the model difficult to read and maintain.

Describe the solution you'd like I plan to:

  • rewrite the fortios model to make it simpler.
  • produce YAML simulation files
  • remove | grep . from the commands as we can handle the pager
  • probably add an if statement on cmd that is evaluated at runtime, something like cmd 'show full-configuration', if: -> { vars(:fullconfig) }

Other ideas are welcome and can be added to this issue.

I have no fortigates with vdoms, so I won't be enable to test everything. As this change could break the FortiOS model for some users, I plan to announce it in the Release notes of 0.35, and make the change in 0.36, so that interested users can test the model (and provide YAML simulation files) before the 0.36 release. => Setting the Milestone to 0.35 for now, in order to remember it when releasing 0.35.

Describe alternatives you've considered Adding more commands into to model without rewriting it. I think cleaning the model is a better solution and worth the effort.

robertcheramy avatar Nov 28 '25 20:11 robertcheramy