oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Update edgecos.rb

Open dhooper6430 opened this issue 1 year ago • 1 comments

Fix multiple temperature sensors reporting and multiple fan units reporting fan speeds that can be configured to be dynamic

Pre-Request Checklist

  • [ ] Passes rubocop code analysis (try rubocop --auto-correct)
  • [ ] Tests added or adapted (try rake test)
  • [ ] Changes are reflected in the documentation
  • [ ] User-visible changes appended to CHANGELOG.md

Description

dhooper6430 avatar Aug 19 '24 04:08 dhooper6430

Output of 'show system' from a EdgeCore ECS5520-18X:

ECS5520-18X-CONSOLE#show system
System Description : ECS5520-18X
System OID String  : 1.3.6.1.4.1.259.10.1.51.102
System Information
 System Up Time         : 31 days, 14 hours, 9 minutes, and 19.90 seconds
 System Name            : ECS5520-18X
 System Location        : Some Location
 System Contact         :
 MAC Address (Unit 1)   : 00-00-00-00-00
 Web Server             : Enabled
 Web Server Port        : 80
 Web Secure Server      : Enabled
 Web Secure Server Port : 443
 Telnet Server          : Enabled
 Telnet Server Port     : 23
 Authentication Login   :  Local RADIUS None
 Authentication Enabled :  Local RADIUS None
 Jumbo Frame            : Enabled
 Large MMU              : Disabled

System Fan:
 Force Fan Speed Full   : Disabled
Unit 1
 Fan 1: Ok                    Fan 2: Ok                    Fan 3: Ok
 Fan 1 speed:  5572 rpm      Fan 2 speed:  5781 rpm      Fan 3 speed:  5869 rpm


System Temperature:
Unit 1
 Temperature 1:  34 degrees     Temperature 2:  26 degrees

Unit 1

 Main Power Status      : Up
 Redundant Power Status : Not present

dhooper6430 avatar Aug 19 '24 04:08 dhooper6430

Thank you for your contribution.

  • Please provide a unit test for the model. You will need to rebase / merge from master in order to use model_helper.rb in the unit test.
  • Please document your changes in CHANGELOG.md

robertcheramy avatar Aug 30 '24 13:08 robertcheramy

Update - consider the unit test point as optional - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so. Please just document your changes in CHANGELOG.md

robertcheramy avatar Sep 03 '24 07:09 robertcheramy