ytti
uplink_olt_model_add
Description
Added UPLINK olt support. V-SOL olt also might work as uplink is rebrand of v-sol in some way. not tested on V-SOL though.
Some part of the code was taken from https://gist.github.com/mdpuma/0df4bc4fe6dd8d0aad6d0445902a9f63 and some was generated by Mistral AI.
P:S: Not a ruby dev, just a network engineer who was able to make it work and wanted to share with the community.
Please document your change in CHANGELOG.md and add the model in docs/Supported-OS-Types.md
The code must pass rubocop and rake test.
Have a look at: https://github.com/ytti/oxidized/blob/master/CONTRIBUTING.md#code-like-a-ruby-professional
Please document your change in CHANGELOG.md and add the model in docs/Supported-OS-Types.md
The code must pass
rubocopandrake test. Have a look at: https://github.com/ytti/oxidized/blob/master/CONTRIBUTING.md#code-like-a-ruby-professional
Finally made time to do the test and updated the files today. Let me know if everything is fine or not. Thank you.
@AAm-kun you should ask @robertcheramy to review, not me.
I find i hard to find any information on the vendor 'uplink' and 'EP4440' seems a specific device, not an network OS. Is OLT the OS then? But yet you add EP4440 to the OS list. Just my two cents.
@systeembeheerder Well Uplink is a rebrand of VSOL if I am not wrong. The OS is same, at least what I saw the webui in youtube videos.
Was not sure what to put in the OS, as there are nothing about this device on google. But saw in the supported list there were some os same name as devices that was the reasoning for putting EP4440. EP4440 is not a specific device either, it is a prefix of multiple devices which shares the same OS. This is basically what my device shows.
@robertcheramy please review when you have time.
The PR looks good, I will be happy to merge it into master after following changes:
- Please provide a unit test for the model. You will need to rebase / merge from master in order to use
model_helper.rbin the unit test. - Please document your changes in CHANGELOG.md
Update - consider the unit test point as optional - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so. Please just document your changes in CHANGELOG.md
Update - consider the unit test point as optional - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so. Please just document your changes in CHANGELOG.md
change-log has been added. Let me know if anything else is missing.