oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Fix for slackdiff.

Open Punicaa opened this issue 1 year ago • 1 comments

Pre-Request Checklist

  • [ ] Passes rubocop code analysis (try rubocop --auto-correct)
  • [ ] Tests added or adapted (try rake test)
  • [ ] Changes are reflected in the documentation
  • [X] User-visible changes appended to CHANGELOG.md

Description

  • Updated slackdiff.rb to use slack_ruby_client instead of slack-api.
  • Updated default timeout from 20 to 60.

Fixes users experiencing the following error:

ERROR -- : Hook slack (#SlackDiff:0x00005572c9621e20) failed (#<NameError: uninitialized constant Slack::Client>) for event :post_store #2697

Punicaa avatar Apr 29 '24 11:04 Punicaa

I miss the update of the default timeout in the diff. Can you check that? Can you also merge master into your branch (or rebase it, as you which), and modify Changelog so that the changes are under the unreleased Version?

robertcheramy avatar May 13 '24 13:05 robertcheramy

Thanks for the comment. Changes from Master pulled and made changes to Changelog and actually changed the timeout.

Punicaa avatar Jun 11 '24 15:06 Punicaa

Something whent terribly wrong here, as many commits where integrated in this PR. Mabe a git rebase would bring some clarity in the PR?

robertcheramy avatar Jun 14 '24 12:06 robertcheramy

Why should the default timeout be changed? If you don't like it, you can change it in your configuration.

robertcheramy avatar Jun 14 '24 12:06 robertcheramy

Something went terribly wrong here, as many commits where integrated in this PR. Mabe a git rebase would bring some clarity in the PR?

I've rebased your branch. Be sure to update your branch before submitting more commits. You may need a `git reset --hard.

robertcheramy avatar Jun 14 '24 12:06 robertcheramy

Thanks for fixing the branch. The timeout of 20 seconds is too few for devices with more complicated configurations, like firewalls, or some switches. It's also on the low-end when devices need to be pulled over higher latency. When setting up oxidized in our environment it was "broken" out of the box because of this. I figured this could help some first time users, but I can also leave it out and we'll just go with the slack fix.

Punicaa avatar Jun 14 '24 14:06 Punicaa

You can change the timeout in your configuration file:

timeout: 20

I'll revert the timeout change an merge into master.

robertcheramy avatar Jun 17 '24 09:06 robertcheramy