oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Fix arubaOS-CX power-consumption changes logged

Open TerraTalpi opened this issue 1 year ago • 4 comments

Pre-Request Checklist

  • [x] User-visible changes appended to CHANGELOG.md

Description

Fix #3142. The ArubaOS-CX switches with the new Long Support Release (LSR) Version FL.10.13.xxxx introduce a new sub-command show environment power-consumption. This displays current power consumption values for all switches in the stack. This is a fix, to exclude all actual power consumption values from the output.

TerraTalpi avatar Apr 29 '24 08:04 TerraTalpi

Hi @TerraTalpi , I tested out the changes in your PR, and i found that the changes DO work, but leave soemthing to be desired...

it will still produce a "change" if any of the power numbers changes from 2 digits to 3 digits (ie if from one oxidixed run to another, instantaneous power goes from "99.50" to "103.50", then the output after that PR will go from this to this:

#    6300M 48SR5 CL6 PoE 4SFP56 Swc      <power>    <power>
#    6300M 48SR5 CL6 PoE 4SFP56 Swc      <power>     <power>

also, it doesn't capture or strip total power consumption, so any changes there will still be captured

alextremblay avatar May 01 '24 13:05 alextremblay

Dear maintainers, ready to merge from my side, I have vastly expanded support for multiple arubaOS-CX switch series and chassis switches. For details, see related issue with the deeper analysis of the outputs that may come and must be parsed.

TerraTalpi avatar May 08 '24 06:05 TerraTalpi

@alextremblay - does the PR now works for you?

robertcheramy avatar May 13 '24 08:05 robertcheramy

Hi @robertcheramy thank you for approving the CI/CD runs. I have corrected the trailing whitespaces error, sorry for that. Please run the tests again in order for all tests to pass.

TerraTalpi avatar May 13 '24 08:05 TerraTalpi

@alextremblay - I will merge this PR. If you miss something, this can be changed / added afterwards.

robertcheramy avatar May 17 '24 05:05 robertcheramy