oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Change C4CMTS to use EEPROM data for inventory information

Open nickhilliard opened this issue 1 year ago • 1 comments

Pre-Request Checklist

  • [ ] Passes rubocop code analysis (try rubocop --auto-correct)
  • [ ] Tests added or adapted (try rake test)
  • [ ] Changes are reflected in the documentation
  • [ ] User-visible changes appended to CHANGELOG.md

Description

"show inventory" on this platform shows transit information which can change on each login. "show factory-eeprom" shows only persistent data based on the chassis inventory, so is more suitable for oxidized output.

nickhilliard avatar Feb 09 '24 23:02 nickhilliard

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.02%. Comparing base (30ada6b) to head (762d031).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files          33       33           
  Lines        1613     1613           
=======================================
  Hits         1065     1065           
  Misses        548      548           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 09 '24 23:02 codecov-commenter

Thank you @nickhilliard for this PR. Please document the change in CHANGELOG.md.

robertcheramy avatar Feb 16 '24 12:02 robertcheramy