oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

Extended mysql source (TLS support)

Open kastakhov opened this issue 2 years ago • 4 comments

Pre-Request Checklist

  • [ ] Passes rubocop code analysis (try rubocop --auto-correct)
  • [ ] Tests added or adapted (try rake test)
  • [x] Changes are reflected in the documentation
  • [x] User-visible changes appended to CHANGELOG.md

Description

Extended mysql source configuration to include TLS options

Close the issue #2096

kastakhov avatar Apr 05 '22 21:04 kastakhov

I would make this drier. You are repeating yourself. Instead you could make an hash then add SSL keys to the hash if SSL is defined and then call the constructor with the hash.

ytti avatar Apr 06 '22 08:04 ytti

Sorry, but I don't know ruby (have experience with another languages), so I just made it as I understand this and can say that this solution is working in my environment.

kastakhov avatar Apr 06 '22 09:04 kastakhov

I made it a bit clean.

kastakhov avatar Apr 06 '22 20:04 kastakhov

Please fix the merge conflicts

mortzu avatar May 01 '22 02:05 mortzu

@mortzu have done with it (sorry for the late answer)

kastakhov avatar Aug 23 '22 08:08 kastakhov