oxidized icon indicating copy to clipboard operation
oxidized copied to clipboard

add support for Dell N-Series switches

Open wasapi opened this issue 4 years ago • 7 comments

Pre-Request Checklist

  • [ ] Passes rubocop code analysis (try rubocop --auto-correct)
  • [ ] Tests added or adapted (try rake test)
  • [ ] Changes are reflected in the documentation
  • [x] User-visible changes appended to CHANGELOG.md

Description

Add file for N-Series switches. Based on the DellX, with more section replaced by 'terminal length 0' on post_login ("More:" not match on DellN), and add possibility to enable without password.

wasapi avatar Oct 02 '20 08:10 wasapi

Codecov Report

Merging #2194 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2194   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be01808...c8e1e72. Read the comment docs.

codecov-commenter avatar Oct 02 '20 08:10 codecov-commenter

Hi! Thanks for this PR!

This looks good, but seems to borrow much of the construction of the Dell-X model. Is there any fundamental incompatibility that would prevent extending the Dell-X model to also support the Dell-N?

wk avatar Oct 06 '20 22:10 wk

The main incompatibility is the match of "More:" in the dellx model; for N-Series it must match "--More--". Also, I find it more elegant to add a 'post_login' to disable page view, but I don't know if it works with X-Series.

wasapi avatar Oct 07 '20 15:10 wasapi

Hello, I have a Dell N-2048 switch (running image version 6.6.0.10) and I'm using the powerconnect model, it works pretty good. The only problem is it doesn't retrieve the output of the 'show system' command which is fine for me and also the code of the dellx model I think whould have the same problem.

ntokos avatar Oct 21 '20 12:10 ntokos

I didn't take a look at the powerconnect model because the powerconnect 2848 switchs I replaced had almost nothing in the cli, except a show tech-support command. Indeed it seem it can work with N-Series. But N-Series commands are the same as the X-Series, except the more text, it could be nice if someone could test the post_login 'terminal length 0' instead of the expect block, I think it should work. Maybe it should be better if I directly made a pull request for the dellx model.

wasapi avatar Dec 10 '20 17:12 wasapi

Sadly I'm still getting the follow return from a PowerConnect switch using this, another modified file I found, and the original file. It is interesting that it runs the first command no issue, then the second command runs but it only returns the last 4ish lines of a much larger output in the cli.

! ! Machine Description............... Dell Networking Switch ! System Model ID................... N1548P ! Machine Type...................... Dell Networking N1548P ! Serial Number..................... **************** ! Manufacturer...................... 0xbc00 ! Burned In MAC Address............. ***************** ! System Object ID.................. ********************* ! SOC Version....................... BCM56150_A0 ! HW Version........................ 3 ! CPLD Version...................... 16 ! ! unit active backup current-active next-active ! ---- ----------- ----------- -------------- -------------- ! 1 6.3.3.14 6.6.3.3 6.3.3.14 6.3.3.14 ! 2 6.3.3.14 6.6.3.3 6.3.3.14 6.3.3.14 ! ! System Description: Dell Networking Switch ! USB Port Power Status: ! ---------------------- ! Device Not Present ^ % Invalid input detected at '^' marker.

cemtiger avatar Oct 15 '21 14:10 cemtiger

Please fix the merge conflict

mortzu avatar May 13 '22 18:05 mortzu