ytti

Results 163 comments of ytti
trafficstars

Uh, forgot this one. This is broken by https://github.com/ytti/oxidized/pull/257 @ElvinEfendi are you bribable to care about this?

based on #3 looks like this was fixed only for CLI and not in the actual class constructor @ElvinEfendi would appreciate if you could take a look

file.rb's `fetch` likely is the culprit. It seems fetch may not be returning a string but an array. When you're doing this, are you also running groups?

Can you try after this change: https://github.com/ytti/oxidized/commit/449522554473f4b9a261ec06ee6961defb30f7bb

I changed it to return nil, if file can't be found, I'm not sure that is actually sensible, of perhaps we should raise the ENOENT error, and let consumer (oxidized-web)...

We already have ':remove_secret' var in configs, which models can use to remove secrets from config. Should we use this, or new? I don't have strong opinion, just pointed it...

If it would be under rest, do you think it would be still logical that models use it to determine if model will remove secrets from config? Clearly this is...

I'm not talking about your proposal. I'm talking about current behaviour of 'remote_secret'. You expressed confusion why it's 'var', and not under 'rest'. I explained, clearly poorly, that it has...

Sorry for being thick, I'm not actual sure what your argument is. Do you think we can 'overload' remove_secret to remove them in web too. Or do you think we...

Ok. Excellent, your use-case proves we can't overload the configurations and need separate toggles for each. So we'll go with your original idea.