ytti

Results 163 comments of ytti
trafficstars

It would be also possible in the model to detect if we are running on cXR (32b QNX) or eXR (64b Linux), storate that in class instance variable, and later...

I do wonder whose role is what. What is models role, what is input methods role? Since obviously in most typical case, we use some CLI like mechanism, like SSH...

Do we want to have separate string_navigate methods for HTTP object and JSON file object? I feel like in absense of having good reason to have duplicate methods, we should...

You could add it to 'source.rb' as all sources inherit from it, so then it'll be available in any source. I think it's generic enough, because it has nothing to...

> > I think it's generic enough, because it has nothing to do technically with JSON, it's more navigating any ruby hash like object. > > There is a section...

> Yes, we are on the same page with the string_navigate method. > > The jsonfile source class had a second method duplicated from the csv source class open_file. Should...

Looks good to me.

It's probably just too relaxed prompt detection, ftp#@1 loks like highly likely culprit of false positive.

I do think we should be able to terminate the SSH session after we run pre_logout, regardless if pre_logout causes disconnect or not. If someone can give me access to...

Multiple sources are not supported, it wouldn't be particularly hard to add multiple source support, but it couldn't possibly work in suggested config, because you overwrite the 'http' key, it...