youtube-dl icon indicating copy to clipboard operation
youtube-dl copied to clipboard

avconv output

Open danut007ro opened this issue 12 years ago • 7 comments

This pull request is capturing avconv output (at least, don't know about ffmpeg) and is showing how much of the encoding it has done, as percentage.

Also, on my system, the aac codec is marked as experimental, so I used libfaac for aac encoding (if there is another option, that code can be removed)

danut007ro avatar Oct 09 '12 18:10 danut007ro

The commit is ok now, I hope

danut007ro avatar Oct 11 '12 07:10 danut007ro

Perfect, thanks! I will merge it as soon as I'm able to check with ffmpeg.

FiloSottile avatar Oct 11 '12 10:10 FiloSottile

I checked with ffmpeg and it looked ok. Can someone else also check?

danut007ro avatar Oct 19 '12 07:10 danut007ro

-1. The changes in line 74 to 80 undo 65f934dc930f7996e137d61dd80ef092f9075532 without an explanation, and will therefore break Windows systems.

phihag avatar Oct 19 '12 10:10 phihag

A merge error, I guess, he committed it before 65f934d and rebased after...

FiloSottile avatar Oct 19 '12 11:10 FiloSottile

is this commit will be merged to master? It would be nice to have audio converting progress status.

stolendog avatar May 08 '13 11:05 stolendog

Definitively merging this, even it requires some more cleanup and testing work. Also, we would need something like that for rtmpdump, too...

FiloSottile avatar May 20 '13 08:05 FiloSottile