youtube-dl icon indicating copy to clipboard operation
youtube-dl copied to clipboard

deezer download

Open Marcioghiraldelli opened this issue 2 years ago • 11 comments

Hello, I notice that deezer download works well, but it only downloads 30 seconds of audio. Is there an alternative to this?

Marcioghiraldelli avatar Jul 07 '22 23:07 Marcioghiraldelli

See https://github.com/yt-dlp/yt-dlp/issues/1591.

dirkf avatar Jul 08 '22 06:07 dirkf

@dirkf as I understand it, it will not be possible more than 30 seconds, right?

Marcioghiraldelli avatar Jul 08 '22 13:07 Marcioghiraldelli

The original PR, mentioned in the link, is apparently invalid, in that it no longer matches what the site does. It does contain a Blowfish crypto module that might still be useful, here or elsewhere.

The discussion in the linked issue indicates that it might be possible to develop a PR that extracts the full tracks without DMCA infringement but it would have to be carefully assessed. Personally, I won't be doing this but others are welcome to try, whether for personal use or as a PR, subject to the considerations I mentioned.

dirkf avatar Jul 08 '22 14:07 dirkf

@89z I liked your idea. Do you have information on how to use your extractor?

Marcioghiraldelli avatar Jul 08 '22 22:07 Marcioghiraldelli

@89z https://www.deezer.com/br/track/1754288087

Marcioghiraldelli avatar Jul 08 '22 22:07 Marcioghiraldelli

Hello, I was able to fix the deezer extractor, and uncypher the files. My PR was never merged and then the repo was taken down. I'll try to fix it in September.

See #22074

LucBerge avatar Aug 05 '22 02:08 LucBerge

I'll try to fix it in September.

I don't know if thats a good idea. I support a Deezer extractor, in fact I wrote my own. However its clear that Deezer will pursue some implementations. However I have also seen other valid implementations, that are pretty old and still standing. I guess we can see if a maintainer wants to give their opinion. Correction. It seems the DMCA in question was for YouTube-DL itself, and some forks:

https://github.com/github/dmca/blob/master/2020/10/2020-10-23-RIAA.md

since we all know that challenge ultimately failed, then it might be fine to add a Deezer extractor at this point, since it was RIAA and not Deezer that made the claim.

89z avatar Aug 05 '22 03:08 89z

Correction. It seems the DMCA in question was for YouTube-DL itself, and some forks:

https://github.com/github/dmca/blob/master/2020/10/2020-10-23-RIAA.md

since we all know that challenge ultimately failed, then it might be fine to add a Deezer extractor at this point, since it was RIAA and not Deezer that made the claim.

Indeed, it wasn't taken down because of me. I should have specify it...

However, my implementation is not "correct" since I bypass the authentication !

LucBerge avatar Aug 05 '22 03:08 LucBerge

Wait a minute, my code was merged to yt-dlp from my fork of youtube-dl

This is my code 😄 . Does it still work ?

Edit: This is not the latest version of my code. It does not support full song and uncypher. The fork have been made too early of from the wrong branch of my repo.

Edit 2: The merged branch was deezer while the full song support was on the deezer-uncypher branch as stayed here.

LucBerge avatar Aug 05 '22 04:08 LucBerge

As above, the question is whether PR #22074 still works.

Easiest is if you can get your repo unblocked (quote #27013), test the branch and commit any necessary changes to match the site there. Otherwise you can clone the PR code into a new branch and make a replacement PR from it (with whatever necessary changes).

dirkf avatar Aug 05 '22 10:08 dirkf

@dirkf I could not get my repo unlocked. Check this PR

LucBerge avatar Sep 15 '22 17:09 LucBerge