youtube-dl
youtube-dl copied to clipboard
[Paramount+] Back-port Paramount+ extractor (etc) from yt-dlp
Please follow the guide below
Before submitting a pull request make sure you have:
- [x] Searched the bugtracker for similar pull requests
- [x] Read adding new extractor tutorial
- [x] Read youtube-dl coding conventions and adjusted the code to meet them
- [x] Covered the code with tests (note that PRs without tests will be REJECTED)
- [x] Checked the code with flake8
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
- [ ] I am the original author of this code and I am willing to release it under Unlicense
- [x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)
What is the purpose of your pull request?
- [x] Bug fix
- [ ] Improvement
- [x] New extractor
- [ ] New feature
Description of your pull request and other information
The structure of pages at paramountplus.com has changed, as well that of some pages handled by other extractor modules such as cbs.py and theplatform.py.
This PR back-ports the required changes from yt-dlp , with some small changes to match the platform and API. ParamountPlus and ParamountPlusSeries extractors are added, with supporting changes to CBS and ThePlatform extractors.
A _match_valid_url()
method is included in the ThePlatformBaseIE
class, which can be removed if PR #30046 has been merged.
The PR is expected (as far as possible) to
- resolve #29564
- resolve #30066
- resolve #30197
- resolve #30247
- resolve #30491.
The tests needed to be run in the USA before merging, as the ParamountPlus URLs are strongly geo-blocked. The CI runs seem to have passed that check.
Thanks @dodrian, @Sipherdrakon for additional updates from yt-dlp.
I would certainly love to see this issue resolved
Looks like some that fails with this patch:
#29351 #29038
You identified the second as DRM. I would think that something as astonishingly desirable as "rupaul-s-drag-race-drama-queens" (in the first issue) might also be protected? In the UK they all look the same as ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden
Looks like some that fails with this patch: #29351 #29038
You identified the second as DRM. I would think that something as astonishingly desirable as "rupaul-s-drag-race-drama-queens" (in the first issue) might also be protected? In the UK they all look the same as
ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden
All movies are DRMed, and in my experience some TV shows are DRMed as well - even to the point where some episodes are DRM and some are not in the same season.
There are definitely a few hiccups within paramount+ that you have to look out for. One being a bug that causes audio looping, this has been confirmed to be server side and not a problem with youtube-dl.
And another that mostly happens with nickelodeon shows where the length that youtube-dl downloads is different than the reported length because video chunks are just missing, I think that happened a lot on fairly oddparents.
Then of course random episodes within seasons, for example 1 episode out of the entire series of Zoey 101 is drm, and then the entire season 5 of TMNT.
And then yes all movies I've come across are drm.
Oh and also random episodes won't have subtitles that can be found. Even though they show up in the player.
So in all paramount+ is a giant headache and a half.
On Wed, Apr 13, 2022, 9:33 AM Dorian Westacott @.***> wrote:
Looks like some that fails with this patch: #29351 https://github.com/ytdl-org/youtube-dl/issues/29351 #29038 https://github.com/ytdl-org/youtube-dl/issues/29038
You identified the second as DRM. I would think that something as astonishingly desirable as "rupaul-s-drag-race-drama-queens" (in the first issue) might also be protected? In the UK they all look the same as ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden
All movies are DRMed, and in my experience some TV shows are DRMed as well
- even to the point where some episodes are DRM and some are not in the same season.
— Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/pull/30085#issuecomment-1098056477, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLSCXT2HGCMYUAHENAZLFLVE3EJTANCNFSM5FYWB2BA . You are receiving this because you were mentioned.Message ID: @.***>
So should we take out the URL match for movies
and/or add an explicit check for DRM?