youtube-dl icon indicating copy to clipboard operation
youtube-dl copied to clipboard

[extractor/rtve.es:live] Fix title and video id discovering

Open mondeja opened this issue 2 years ago • 1 comments

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New extractor
  • [ ] New feature

Description of your pull request and other information

Update title and video id discovering process for RTVE.es live streams.

mondeja avatar Aug 18 '21 12:08 mondeja

This PR looks reasonable to me. Is it just because of a lack of time that it wasn't merged yet or is it something that still need to be changed?

By the way, would it be possible to fetch/embed the subtitles as well? Similar to the other platforms where --list-subs, --write-sub, --all-subs etc is working?

It seems that there was once another Python script for this.

alexanderadam avatar Aug 02 '22 20:08 alexanderadam