youtube-dl
youtube-dl copied to clipboard
Pac 12
Please follow the guide below
- You will be asked some questions, please read them carefully and answer honestly
- Put an
x
into all the boxes [ ] relevant to your pull request (like that [x]) - Use Preview tab to see how your pull request will actually look like
Before submitting a pull request make sure you have:
- [x] Searched the bugtracker for similar pull requests
- [x] Read adding new extractor tutorial
- [x] Read youtube-dl coding conventions and adjusted the code to meet them
- [x] Covered the code with tests (note that PRs without tests will be REJECTED)
- [x] Checked the code with flake8
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
- [x] I am the original author of this code and I am willing to release it under Unlicense
- [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)
What is the purpose of your pull request?
- [ ] Bug fix
- [ ] Improvement
- [x] New extractor
- [ ] New feature
Description of your pull request and other information
youtube-dl support for https://pac-12.com.
Works on pages that have a free video. Does not work on pages
that require a TV provider login to see the video.
resolves #31417
- Read coding conventions.
- Parse JSON instead of extract from JSON with regexes.
Okay. What I am extracting from is an html page, but I guess what I'm matching is embedded JSON. I really didn't know what it was! I'll see if JSON parsing functions in youtube-dl will crunch it. Thanks.
Can you take a look again? This version is better, at least.
This version meets the coding standard as far as I know. Can you look again? If there are still issues, can you be specific about what they are? I'm happy to clean things up as needed. Thanks!
Can you look again? I believe this is ready for merge.
Is there a chance of someone looking at this contribution again? I made the changes that were requested in 2021, but the pull request was ignored after that.
I believe that there is no site support request issue for this site: please paste the site support request template into the PR and complete it; otherwise reference the issue that this would close using the magic GH words resolves #nnnn
at the end of the original PR text.
resolves #31417
I believe that there is no site support request issue for this site: please paste the site support request template into the PR and complete it; otherwise reference the issue that this would close using the magic GH words
resolves #nnnn
at the end of the original PR text.
Done, thanks!