youtube-dl icon indicating copy to clipboard operation
youtube-dl copied to clipboard

Pac 12

Open TimothyPMann opened this issue 4 years ago • 9 comments

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [ ] Bug fix
  • [ ] Improvement
  • [x] New extractor
  • [ ] New feature

Description of your pull request and other information

youtube-dl support for https://pac-12.com.

Works on pages that have a free video.  Does not work on pages
that require a TV provider login to see the video.

resolves #31417

TimothyPMann avatar Feb 13 '21 20:02 TimothyPMann

  1. Read coding conventions.
  2. Parse JSON instead of extract from JSON with regexes.

dstftw avatar Feb 13 '21 21:02 dstftw

Okay. What I am extracting from is an html page, but I guess what I'm matching is embedded JSON. I really didn't know what it was! I'll see if JSON parsing functions in youtube-dl will crunch it. Thanks.

TimothyPMann avatar Feb 13 '21 21:02 TimothyPMann

Can you take a look again? This version is better, at least.

TimothyPMann avatar Feb 14 '21 03:02 TimothyPMann

This version meets the coding standard as far as I know. Can you look again? If there are still issues, can you be specific about what they are? I'm happy to clean things up as needed. Thanks!

TimothyPMann avatar Feb 21 '21 02:02 TimothyPMann

Can you look again? I believe this is ready for merge.

TimothyPMann avatar May 09 '21 04:05 TimothyPMann

Is there a chance of someone looking at this contribution again? I made the changes that were requested in 2021, but the pull request was ignored after that.

TimothyPMann avatar Nov 30 '22 20:11 TimothyPMann

I believe that there is no site support request issue for this site: please paste the site support request template into the PR and complete it; otherwise reference the issue that this would close using the magic GH words resolves #nnnn at the end of the original PR text.

dirkf avatar Dec 11 '22 13:12 dirkf

resolves #31417

TimothyPMann avatar Dec 13 '22 22:12 TimothyPMann

I believe that there is no site support request issue for this site: please paste the site support request template into the PR and complete it; otherwise reference the issue that this would close using the magic GH words resolves #nnnn at the end of the original PR text.

Done, thanks!

TimothyPMann avatar Dec 13 '22 22:12 TimothyPMann