yt icon indicating copy to clipboard operation
yt copied to clipboard

yt filter docs having failing ipython notebooks present

Open chummels opened this issue 1 year ago • 8 comments

Bug report

Bug summary

I noticed some failing ipython notebooks in the filtering docs, due to "not implemented errors".

chummels avatar Aug 01 '23 22:08 chummels

Hey @chummels, I just checked the link mentioned for missing images and found no icons indicating missing images. Can you specify the heading below which you found those icons so that I can check again?

SanjayManjunath avatar Aug 03 '23 08:08 SanjayManjunath

Hi @SanjayManjunath . It appears that all of the missing images are now displaying correctly. Perhaps it was an intermittent build issue? Either way, it seems to be addressed. However, the ipython notebooks are still failing in the filtering docs. I'll change the topic of this Issue to reflect that.

chummels avatar Aug 09 '23 17:08 chummels

@chummels I'm new to the repo, can you please help me locate files like these? "Enzo_64/DD0042/data0042"

SanjayManjunath avatar Aug 11 '23 17:08 SanjayManjunath

I can help here ! The docs are built using a collection of sample datasets that should all be publicly available here: https://yt-project.org/data/

It can however be a little tricky to connect the dots between the names on the web page and the path string which is used to load the data in docs. However the exact one you're asking for is by far the most widely used and is also known as IsolatedGalaxy. One convenient way to download it is to install pandas, pooch and h5py and run import yt; ds = yt.load_sample("IsolatedGalaxy")

neutrinoceros avatar Aug 11 '23 18:08 neutrinoceros

Hey @neutrinoceros, thanks for the help! :)

SanjayManjunath avatar Aug 13 '23 08:08 SanjayManjunath

@chummels I looked up the notebooks and like you've mentioned they are failing. Hey @neutrinoceros, why are we not getting the expected output? Please share if you know anything about this issue.

SanjayManjunath avatar Aug 14 '23 06:08 SanjayManjunath

I've opened https://github.com/yt-project/yt/pull/4631 to fix one of the errors that are visible in the filtering docs. I don't know how the rest of them should be fixed.

Also @SanjayManjunath, I made a mistake: Enzo_64 is a different dataset than IsolatedGalaxy. You can install it with yt.load_sample("Enzo_64") (the requirements are unchanged)

neutrinoceros avatar Aug 15 '23 07:08 neutrinoceros

Thank You, @neutrinoceros! It works with "Enzo_64".

SanjayManjunath avatar Aug 16 '23 05:08 SanjayManjunath