yt
yt copied to clipboard
yt-project
[WIP] ENH: Enable exporting GAMER and FLASH datasets to octrees
PR Summary
Initial value: This allows passing in domain_dimensions to the load_octree function, so that you can load octrees that don't have just the one root cell.
New and revised: This PR will enable FLASH and GAMER datasets to be exposed as Octree datasets, which will be a method for testing improvements in performance.
PR Checklist
- [x] New features are documented, with docstrings and narrative docs
- [ ] Adds a test for any bugs fixed. Adds tests for new features.
close/open to refresh CI now that unrelated failures are resolved on main
@matthewturk Is this still "WIP" or is it actually ready for merging ?
So I think it needs another pass from me. But I will check today!
It's currently -8F here with 24MPH winds! Once I get the place under control I'll take a look over this one. Should be a fun task for a funny day.
Best time for a feature freeze!
23 Dec 2022 14:06:10 Matthew Turk @.***>:
So I think it needs another pass from me. But I will check today!
It's currently -8F here with 24MPH winds! Once I get the place under control I'll take a look over this one. Should be a fun task for a funny day.
— Reply to this email directly, view it on GitHub[https://github.com/yt-project/yt/pull/4134#issuecomment-1363938395], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABJJII7MDPMH6TG6AKXCCODWOWPUBANCNFSM6AAAAAAQPAPSS4]. You are receiving this because you are subscribed to this thread.[Tracking image][https://github.com/notifications/beacon/ABJJII7BN4QMNPL2TKM6OY3WOWPUBA5CNFSM6AAAAAAQPAPSS6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRJQGFW.gif]
Oh, my. That is a hall of fame review comment.
On Fri, Dec 23, 2022, 7:20 AM Corentin Cadiou @.***> wrote:
Best time for a feature freeze!
23 Dec 2022 14:06:10 Matthew Turk @.***>:
So I think it needs another pass from me. But I will check today!
It's currently -8F here with 24MPH winds! Once I get the place under control I'll take a look over this one. Should be a fun task for a funny day.
— Reply to this email directly, view it on GitHub[ https://github.com/yt-project/yt/pull/4134#issuecomment-1363938395], or unsubscribe[ https://github.com/notifications/unsubscribe-auth/ABJJII7MDPMH6TG6AKXCCODWOWPUBANCNFSM6AAAAAAQPAPSS4 ]. You are receiving this because you are subscribed to this thread.[Tracking image][ https://github.com/notifications/beacon/ABJJII7BN4QMNPL2TKM6OY3WOWPUBA5CNFSM6AAAAAAQPAPSS6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRJQGFW.gif ]
— Reply to this email directly, view it on GitHub https://github.com/yt-project/yt/pull/4134#issuecomment-1363948411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVXO64MZ64JYB6QT4J7FDWOWRKBANCNFSM6AAAAAAQPAPSS4 . You are receiving this because you were mentioned.Message ID: @.***>
So it's ready for review but I don't want it to be merged quite yet -- a few more minor things I want to address.
looks like this PR grew a couple minor conflicts. I'm also waiting for my comments to be adressed, but it seems like a low-hanging fruit on the journey to yt 4.2