falco icon indicating copy to clipboard operation
falco copied to clipboard

[BUG] cross-compile failing

Open ysugimoto opened this issue 1 year ago • 3 comments

Describe the problem

When I make a new release, accidentally CI process failed. I'm guessing our code includes platform dependency since https://github.com/ysugimoto/falco/pull/66 has been merged.

On CI, use ubuntu-latest, linux-amd64:

  • linux: success
  • darwin-amd64: fail
  • darwin-arm64: fail

It should be fixed to release successfully.

VCL code that cause the problem N/A Screenshots Screen Shot 2022-07-21 at 18 11 28

Expected behavior All platform binaries should be compiled and release successfully. A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: Ubuntu (GitHub Actions)
  • Shell bash

Additional context Add any other context about the problem here.

ysugimoto avatar Jul 21 '22 09:07 ysugimoto

@shadialtarsha @davinci26 Do you have any plans to fix this?

ysugimoto avatar Jul 21 '22 09:07 ysugimoto

Temporary, I'll revert #66 manually by https://github.com/ysugimoto/falco/pull/88

ysugimoto avatar Jul 21 '22 09:07 ysugimoto

Thanks for reverting! We can fix it, sorry about that we dont use this pipeline so I completely forgot that we need to change this as well.

davinci26 avatar Jul 21 '22 13:07 davinci26