yorc icon indicating copy to clipboard operation
yorc copied to clipboard

Published 20 hours ago • verified publisher icon ystia

Feature/gh 118 aws virtual network

Open HildericSB opened this issue 4 years ago • 7 comments

Pull Request description

Description of the change

Now possible to attach a subnet to AWS instance.

What I did

  • Added VPC creation with nested subnets and SG
  • Added stand alone Subnet creation
  • Added default setup for abstract application definition.

How I did it

  • Updated the tosca aws types to match terraform specs for Subnet and VPC creation
  • Updated the tosca aws types in the A4C-yorc-provider plugins
  • Add default VPC creation that will
  1. create a security group that allow the deploying IP machine
  2. create a internet gateway (IG)
  3. configure the default VPC table to redirect by default to the IG

How to verify it

-Try deploying a ACompute linked with a ANetwork.

Applicable Issues

#Fixes #118

HildericSB avatar Mar 30 '20 09:03 HildericSB

Can't open topology.zip

stefbenoist avatar Apr 06 '20 12:04 stefbenoist

llow to attach an existing

It seems you don't allow to attach an existing vpc to a compute ?

VPC can't be attached to compute instance, only subnet can. This PR is focused on Subnet creation and attachment to an instance.

HildericSB avatar Apr 06 '20 13:04 HildericSB

Ok but we should allow to attach an existing subnet from an existing VPC to a compute ?

stefbenoist avatar Apr 06 '20 13:04 stefbenoist

Ok but we should allow to attach an existing subnet from an existing VPC to a compute ?

Ok got it ! I'll use the subnet_id argument in tosca type and make YORC handle that.

HildericSB avatar Apr 06 '20 15:04 HildericSB

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 24 '20 08:04 sonarqubecloud[bot]

Code Climate has analyzed commit c0641d82 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

View more on Code Climate.

codeclimate[bot] avatar Sep 11 '20 12:09 codeclimate[bot]

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

76.5% 76.5% Coverage
5.7% 5.7% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here

sonarqubecloud[bot] avatar Sep 11 '20 12:09 sonarqubecloud[bot]