musicshare icon indicating copy to clipboard operation
musicshare copied to clipboard

refactor type-graphql authorization

Open yss14 opened this issue 3 years ago • 0 comments

Motivation: At the moment custom permission checks are solved via type-graphql middlewares and not the buildin auth checker functionality. This brings some disadvantages, like not being able to use buildin error handling behaviour and failing silently as proposed here.

Acceptance Criteria:

  • [ ] protected queries, mutations, and fields are decorated by the buildin type-graphql decorators
  • [ ] custom auth checker checks desired permissions
  • [ ] current workarounds are resolved where both errors and data is returned by a graphql query (e.g. https://github.com/yss14/musicshare/pull/2520)

Authoriztation Docs

yss14 avatar Mar 12 '21 12:03 yss14