keymapviz icon indicating copy to clipboard operation
keymapviz copied to clipboard

fix regression error from a6ad816

Open yearski opened this issue 3 years ago • 2 comments

commit a6ad816 reintroduced an older default layout (prior to 23efd74), and replaced the 2u_inner layout (created in e287c9b) with the layout that should be the default.

yearski avatar Jan 06 '22 02:01 yearski

@yearski

I want to align it with the default ASCII art of ergodash in qmk_firmware. If you want to use a different layout, please use the --layout 2u_inner option.

https://github.com/qmk/qmk_firmware/blob/a2ed670eee98cab826e0b959576716cd7e13a946/keyboards/ergodash/rev1/keymaps/default/keymap.c

yskoht avatar Jan 08 '22 07:01 yskoht

The 2u_inner layout is incorrect now, it is swapped with the default.

I'd still suggest my PR over the qmk ASCII art. The qmk ASCII art represents the electrical matrix which does not produce a great visualization (which is what brought me to keymapviz). But of course, this is your project so the decision is yours.

yearski avatar Jan 11 '22 21:01 yearski