Ioannis Siglidis

Hi, sure I can try (although I don't know much of Javascript). Thanks!

Hi @eddiebergman that's great! Let me address the above points (Todos -> T, Changes -> C): T1,2: nosetests seems to be the one that breaks because of callable, see: https://github.com/eddiebergman/GraKeL/actions/runs/3041633008/jobs/4898960711...

tldr; I think nosetests is the main bottleneck right now. Let's replace it with whatever you think is best (pytest?): I have no objection to migrate to the proposed "T1"...

@eddiebergman All tests can be found here: https://github.com/ysig/GraKeL/tree/master/grakel/tests

@eddiebergman > yup I found them, dont worry :) I ran pytest and nosetest side by side and got the same tests collected and all passed. However pytest additionally reported...

So what I see as two main errors for now: 1) https://github.com/ysig/GraKeL/blob/8500dbf6812116459df308396716b7bcae13ef9c/grakel/tools.py#L175 collections.Hashable should probably be replaced by something that is valid for this version of python. 2) Windows errors...

Hi @eddiebergman, [all are passing right now](https://github.com/eddiebergman/GraKeL/actions/runs/3051878668) except [2 windows processes](https://github.com/eddiebergman/GraKeL/actions/runs/3051878668/jobs/4920624330): - I installed python 3.10 on my windows 10 - just with `pip install -e ".[dev]` - but I...

Hi @eddiebergman Sorry for jumping in a bit late. That's amazing work and thank you so much for pinning down this problem. Lovasz has always been a pain due to...

Hi @eddiebergman thank you so much! Two final things I would like you to add before I merge this PR is: 1. Previously we had this script that would upload...

Please have a look here: https://ysig.github.io/GraKeL/0.1a8/documentation/introduction.html or here: https://ysig.github.io/GraKeL/0.1a8/auto_examples/erdos_renyi.html#sphx-glr-auto-examples-erdos-renyi-py On Wed, Sep 21, 2022 at 2:58 PM JXn-XMU ***@***.***> wrote: > *Is your feature request related to a problem? Please...