Dual Kawase Does Not Respect Rounded Corners

[XPhyro]

Platform

Linux archlinux 5.16.5-arch1-1 #1 SMP PREEMPT Tue, 01 Feb 2022 21:42:50 +0000 x86_64 GNU/Linux

GPU, drivers, and screen setup

NVidia GTX 1060, nvidia-drivers 510.47.03, two monitors configured side-by-side with xrandr

name of display: :0 display: :0 screen: 0 direct rendering: Yes Memory info (GL_NVX_gpu_memory_info): Dedicated video memory: 6144 MB Total available memory: 6144 MB Currently available dedicated video memory: 5569 MB OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: NVIDIA GeForce GTX 1060/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 510.47.03 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile

OpenGL version string: 4.6.0 NVIDIA 510.47.03 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none)

OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 510.47.03 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

Environment

bspwm

picom version

Diagnostics

Version: vgit-92896

Extensions:

• Shape: Yes
• XRandR: Yes
• Present: Present

Misc:

• Use Overlay: Yes
• Config file used: /home/xphyro/.config/picom.conf

Drivers (inaccurate):

NVIDIA, modesetting

Backend: glx

• Driver vendors:
• GLX: NVIDIA Corporation
• GL: NVIDIA Corporation
• GL renderer: NVIDIA GeForce GTX 1060/PCIe/SSE2

Configuration:

Configuration file

#################################
#             Shadows           #
#################################


# Enabled client-side shadows on windows. Note desktop windows
# (windows with '_NET_WM_WINDOW_TYPE_DESKTOP') never get shadow,
# unless explicitly requested using the wintypes option.

# shadow = false
shadow = false;

# The blur radius for shadows, in pixels. (defaults to 12)
# shadow-radius = 12
shadow-radius = 7;

# The opacity of shadows. (0.0 - 1.0, defaults to 0.75)
# shadow-opacity = .75

# The left offset for shadows, in pixels. (defaults to -15)
# shadow-offset-x = -15
shadow-offset-x = -7;

# The top offset for shadows, in pixels. (defaults to -15)
# shadow-offset-y = -15
shadow-offset-y = -7;

# Red color value of shadow (0.0 - 1.0, defaults to 0).
# shadow-red = 0

# Green color value of shadow (0.0 - 1.0, defaults to 0).
# shadow-green = 0

# Blue color value of shadow (0.0 - 1.0, defaults to 0).
# shadow-blue = 0

# Hex string color value of shadow (#000000 - #FFFFFF, defaults to #000000). This option will override options set shadow-(red/green/blue)
# shadow-color = "#000000"

# Specify a list of conditions of windows that should have no shadow.
# examples:
#   shadow-exclude = "n:e:Notification";

# shadow-exclude = []
# shadow-exclude = [
#   "name = 'Notification'",
#   "class_g = 'Conky'",
#   "class_g ?= 'Notify-osd'",
#   "class_g = 'Cairo-clock'",
#   "_GTK_FRAME_EXTENTS@:c"
# ];

# Specify a list of conditions of windows that should have no shadow painted over, such as a dock window.
# clip-shadow-above = []

# Specify a X geometry that describes the region in which shadow should not
# be painted in, such as a dock window region. Use
#    shadow-exclude-reg = "x10+0+0"
# for example, if the 10 pixels on the bottom of the screen should not have shadows painted on.

# shadow-exclude-reg = ""

# Crop shadow of a window fully on a particular Xinerama screen to the screen.
# xinerama-shadow-crop = false


#################################
#           Fading              #
#################################


# Fade windows in/out when opening/closing and when opacity changes,
#  unless no-fading-openclose is used.
# fading = false
fading = true;

# Opacity change between steps while fading in. (0.01 - 1.0, defaults to 0.028)
# fade-in-step = 0.028
fade-in-step = 0.03;

# Opacity change between steps while fading out. (0.01 - 1.0, defaults to 0.03)
# fade-out-step = 0.03
fade-out-step = 0.03;

# The time between steps in fade step, in milliseconds. (> 0, defaults to 10)
# fade-delta = 10

# Specify a list of conditions of windows that should not be faded.
# fade-exclude = []

# Do not fade on window open/close.
# no-fading-openclose = false

# Do not fade destroyed ARGB windows with WM frame. Workaround of bugs in Openbox, Fluxbox, etc.
# no-fading-destroyed-argb = false


#################################
#   Transparency / Opacity      #
#################################


# Opacity of inactive windows. (0.1 - 1.0, defaults to 1.0)
# inactive-opacity = 1
inactive-opacity = 0.8;

# Opacity of window titlebars and borders. (0.1 - 1.0, disabled by default)
# frame-opacity = 1.0
frame-opacity = 0.7;

# Let inactive opacity set by -i override the '_NET_WM_WINDOW_OPACITY' values of windows.
# inactive-opacity-override = true
inactive-opacity-override = false;

# Default opacity for active windows. (0.0 - 1.0, defaults to 1.0)
# active-opacity = 1.0

# Dim inactive windows. (0.0 - 1.0, defaults to 0.0)
# inactive-dim = 0.0

# Specify a list of conditions of windows that should never be considered focused.
# focus-exclude = []
# focus-exclude = [ "class_g = 'Cairo-clock'" ];

# Use fixed inactive dim value, instead of adjusting according to window opacity.
# inactive-dim-fixed = 1.0

# Specify a list of opacity rules, in the format `PERCENT:PATTERN`,
# like `50:name *= "Firefox"`. picom-trans is recommended over this.
# Note we don't make any guarantee about possible conflicts with other
# programs that set '_NET_WM_WINDOW_OPACITY' on frame or client windows.
# example:
#    opacity-rule = [ "80:class_g = 'URxvt'" ];

# opacity-rule = []


#################################
#           Corners             #
#################################

# Sets the radius of rounded window corners. When > 0, the compositor will
# round the corners of windows. Does not interact well with
# `transparent-clipping`.
corner-radius = 16

# Exclude conditions for rounded corners.
rounded-corners-exclude = [
    "window_type = 'dock'",
    "window_type = 'desktop'",
    #"class_g = 'Rofi'",
];


#################################
#     Background-Blurring       #
#################################


# Parameters for background blurring, see the *BLUR* section for more information.

blur-method = "dual_kawase"; # only works with glx and experimental backends
# blur-method = "kernel"

# blur-size = 12

# blur-deviation = false

blur-strength = 5


# Blur background of semi-transparent / ARGB windows.
# Bad in performance, with driver-dependent behavior.
# The name of the switch may change without prior notifications.

blur-background = false


# Blur background of windows when the window frame is not opaque.
# Implies:
#    blur-background
# Bad in performance, with driver-dependent behavior. The name may change.

blur-background-frame = false


# Use fixed blur strength rather than adjusting according to window opacity.
blur-background-fixed = false


# Specify the blur convolution kernel, with the following format:
# example:
#   blur-kern = "5,5,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1";

# blur-kern = "3x3box";

# 15x15 gaussian kernel of \sigma=25
# blur-kern = "15,15,0.924595,0.93426,0.942518,0.949329,0.95466,0.958486,0.960789,0.961558,0.960789,0.958486,0.95466,0.949329,0.942518,0.93426,0.924595,,0.93426,0.944027,0.952372,0.959253,0.96464,0.968507,0.970834,0.971611,0.970834,0.968507,0.96464,0.959253,0.952372,0.944027,0.93426,,0.942518,0.952372,0.960789,0.967732,0.973167,0.977067,0.979415,0.980199,0.979415,0.977067,0.973167,0.967732,0.960789,0.952372,0.942518,,0.949329,0.959253,0.967732,0.974725,0.980199,0.984127,0.986492,0.987282,0.986492,0.984127,0.980199,0.974725,0.967732,0.959253,0.949329,,0.95466,0.96464,0.973167,0.980199,0.985703,0.989654,0.992032,0.992826,0.992032,0.989654,0.985703,0.980199,0.973167,0.96464,0.95466,,0.958486,0.968507,0.977067,0.984127,0.989654,0.99362,0.996008,0.996805,0.996008,0.99362,0.989654,0.984127,0.977067,0.968507,0.958486,,0.960789,0.970834,0.979415,0.986492,0.992032,0.996008,0.998401,0.9992,0.998401,0.996008,0.992032,0.986492,0.979415,0.970834,0.960789,,0.961558,0.971611,0.980199,0.987282,0.992826,0.996805,0.9992,0.9992,0.996805,0.992826,0.987282,0.980199,0.971611,0.961558,,0.960789,0.970834,0.979415,0.986492,0.992032,0.996008,0.998401,0.9992,0.998401,0.996008,0.992032,0.986492,0.979415,0.970834,0.960789,,0.958486,0.968507,0.977067,0.984127,0.989654,0.99362,0.996008,0.996805,0.996008,0.99362,0.989654,0.984127,0.977067,0.968507,0.958486,,0.95466,0.96464,0.973167,0.980199,0.985703,0.989654,0.992032,0.992826,0.992032,0.989654,0.985703,0.980199,0.973167,0.96464,0.95466,,0.949329,0.959253,0.967732,0.974725,0.980199,0.984127,0.986492,0.987282,0.986492,0.984127,0.980199,0.974725,0.967732,0.959253,0.949329,,0.942518,0.952372,0.960789,0.967732,0.973167,0.977067,0.979415,0.980199,0.979415,0.977067,0.973167,0.967732,0.960789,0.952372,0.942518,,0.93426,0.944027,0.952372,0.959253,0.96464,0.968507,0.970834,0.971611,0.970834,0.968507,0.96464,0.959253,0.952372,0.944027,0.93426,,0.924595,0.93426,0.942518,0.949329,0.95466,0.958486,0.960789,0.961558,0.960789,0.958486,0.95466,0.949329,0.942518,0.93426,0.924595";


# Exclude conditions for background blur.
# blur-background-exclude = []
blur-background-exclude = [
    "window_type = 'dock'",
    "window_type = 'desktop'",
    "_GTK_FRAME_EXTENTS@:c"
];

#################################
#       General Settings        #
#################################

# Enable remote control via D-Bus. See the man page for more details.
# dbus = true

# Daemonize process. Fork to background after initialization. Causes issues with certain (badly-written) drivers.
# daemon = false

# Specify the backend to use: `xrender`, `glx`, or `xr_glx_hybrid`.
# `xrender` is the default one.

# backend = "xr_glx_hybrid"
# backend = "xrender";
backend = "glx";

# Enable/disable VSync.
# vsync = false
vsync = false;

# Enable remote control via D-Bus. See the *D-BUS API* section below for more details.
# dbus = false

# Try to detect WM windows (a non-override-redirect window with no
# child that has 'WM_STATE') and mark them as active.

# mark-wmwin-focused = false
mark-wmwin-focused = true;

# Mark override-redirect windows that doesn't have a child window with 'WM_STATE' focused.
# mark-ovredir-focused = false
mark-ovredir-focused = true;

# Try to detect windows with rounded corners and don't consider them
# shaped windows. The accuracy is not very high, unfortunately.

# detect-rounded-corners = false
detect-rounded-corners = true;

# Detect '_NET_WM_WINDOW_OPACITY' on client windows, useful for window managers
# not passing '_NET_WM_WINDOW_OPACITY' of client windows to frame windows.

# detect-client-opacity = false
detect-client-opacity = true;

# Use EWMH '_NET_ACTIVE_WINDOW' to determine currently focused window,
# rather than listening to 'FocusIn'/'FocusOut' event. Might have more accuracy,
# provided that the WM supports it.

# use-ewmh-active-win = false

# Unredirect all windows if a full-screen opaque window is detected,
# to maximize performance for full-screen windows. Known to cause flickering
# when redirecting/unredirecting windows.

# unredir-if-possible = false

# Delay before unredirecting the window, in milliseconds. Defaults to 0.
# unredir-if-possible-delay = 0

# Conditions of windows that shouldn't be considered full-screen for unredirecting screen.
# unredir-if-possible-exclude = []

# Use 'WM_TRANSIENT_FOR' to group windows, and consider windows
# in the same group focused at the same time.

# detect-transient = false
detect-transient = true;

# Use 'WM_CLIENT_LEADER' to group windows, and consider windows in the same
# group focused at the same time. This usually means windows from the same application
# will be considered focused or unfocused at the same time.
# 'WM_TRANSIENT_FOR' has higher priority if detect-transient is enabled, too.

# detect-client-leader = false

# Resize damaged region by a specific number of pixels.
# A positive value enlarges it while a negative one shrinks it.
# If the value is positive, those additional pixels will not be actually painted
# to screen, only used in blur calculation, and such. (Due to technical limitations,
# with use-damage, those pixels will still be incorrectly painted to screen.)
# Primarily used to fix the line corruption issues of blur,
# in which case you should use the blur radius value here
# (e.g. with a 3x3 kernel, you should use `--resize-damage 1`,
# with a 5x5 one you use `--resize-damage 2`, and so on).
# May or may not work with *--glx-no-stencil*. Shrinking doesn't function correctly.

# resize-damage = 1

# Specify a list of conditions of windows that should be painted with inverted color.
# Resource-hogging, and is not well tested.

# invert-color-include = []

# GLX backend: Avoid using stencil buffer, useful if you don't have a stencil buffer.
# Might cause incorrect opacity when rendering transparent content (but never
# practically happened) and may not work with blur-background.
# My tests show a 15% performance boost. Recommended.

# glx-no-stencil = false

# GLX backend: Avoid rebinding pixmap on window damage.
# Probably could improve performance on rapid window content changes,
# but is known to break things on some drivers (LLVMpipe, xf86-video-intel, etc.).
# Recommended if it works.

# glx-no-rebind-pixmap = false

# glx-copy-from-front = false;
# glx-use-copysubbuffermesa = true;
# glx-swap-method = "undefined";
# glx-use-gpushader4 = true;

# Disable the use of damage information.
# This cause the whole screen to be redrawn everytime, instead of the part of the screen
# has actually changed. Potentially degrades the performance, but might fix some artifacts.
# The opposing option is use-damage

# no-use-damage = false
use-damage = true;

# Use X Sync fence to sync clients' draw calls, to make sure all draw
# calls are finished before picom starts drawing. Needed on nvidia-drivers
# with GLX backend for some users.

# xrender-sync-fence = false

# xrender-sync = true;

# GLX backend: Use specified GLSL fragment shader for rendering window contents.
# See `compton-default-fshader-win.glsl` and `compton-fake-transparency-fshader-win.glsl`
# in the source tree for examples.

# glx-fshader-win = ""

# Force all windows to be painted with blending. Useful if you
# have a glx-fshader-win that could turn opaque pixels transparent.

# force-win-blend = false

# Do not use EWMH to detect fullscreen windows.
# Reverts to checking if a window is fullscreen based only on its size and coordinates.

# no-ewmh-fullscreen = false

# Dimming bright windows so their brightness doesn't exceed this set value.
# Brightness of a window is estimated by averaging all pixels in the window,
# so this could comes with a performance hit.
# Setting this to 1.0 disables this behaviour. Requires --use-damage to be disabled. (default: 1.0)

# max-brightness = 1.0

# Make transparent windows clip other windows like non-transparent windows do,
# instead of blending on top of them.

# transparent-clipping = false

# Set the log level. Possible values are:
#  "trace", "debug", "info", "warn", "error"
# in increasing level of importance. Case doesn't matter.
# If using the "TRACE" log level, it's better to log into a file
# using *--log-file*, since it can generate a huge stream of logs.

# log-level = "debug"
log-level = "warn";

# Set the log file.
# If *--log-file* is never specified, logs will be written to stderr.
# Otherwise, logs will to written to the given file, though some of the early
# logs might still be written to the stderr.
# When setting this option from the config file, it is recommended to use an absolute path.

# log-file = "/path/to/your/log/file"

# Show all X errors (for debugging)
# show-all-xerrors = false

# Write process ID to a file.
# write-pid-path = "/path/to/your/log/file"

# Window type settings
#
# 'WINDOW_TYPE' is one of the 15 window types defined in EWMH standard:
#     "unknown", "desktop", "dock", "toolbar", "menu", "utility",
#     "splash", "dialog", "normal", "dropdown_menu", "popup_menu",
#     "tooltip", "notification", "combo", and "dnd".
#
# Following per window-type options are available: ::
#
#   fade, shadow:::
#     Controls window-type-specific shadow and fade settings.
#
#   opacity:::
#     Controls default opacity of the window type.
#
#   focus:::
#     Controls whether the window of this type is to be always considered focused.
#     (By default, all window types except "normal" and "dialog" has this on.)
#
#   full-shadow:::
#     Controls whether shadow is drawn under the parts of the window that you
#     normally won't be able to see. Useful when the window has parts of it
#     transparent, and you want shadows in those areas.
#
#   clip-shadow-above:::
#     Controls wether shadows that would have been drawn above the window should
#     be clipped. Useful for dock windows that should have no shadow painted on top.
#
#   redir-ignore:::
#     Controls whether this type of windows should cause screen to become
#     redirected again after been unredirected. If you have unredir-if-possible
#     set, and doesn't want certain window to cause unnecessary screen redirection,
#     you can set this to `true`.

wintypes:
{
    tooltip = {
        fade = true;
        shadow = true;
        opacity = 0.75;
        focus = true;
        full-shadow = false;
    };
    dock = {
        shadow = false;
        clip-shadow-above = true;
    };
    dnd = {
        shadow = false;
    };
    popup_menu = {
        opacity = 0.8;
    };
    dropdown_menu = {
        opacity = 0.8;
    };
};


#################################
#             Other             #
#################################

# dbe = false;
# menu-opacity = 0.8;
# alpha-step = 0.06;
# paint-on-overlay = true;
# sw-opti = true;

Steps of reproduction

1. Select dual_kawase blur method.
2. Set non-zero corner-radius.
3. Observe window corners.

Expected behavior

Area trimmed by rounded corners should not be blurred.

Current Behavior

Area trimmed by rounded corners is blurred if dual_kawase is selected. Other blur methods work as expected even with experimental backends enabled.

Other details

blur-method = "kernel";

blur-method = "dual_kawase";

Notice the blurry rectangle with dual_kawase.

[cizordj]

I'm also having this issue, I exaggerated the corner size just to demonstrate

[tryone144]

This is not specific to any blur method — it is just easily visible with the high blur levels that dual_kawase efficiently supports.

Neither of the supported blur methods currently respect the corner-radius setting for stripping off the rounded corners. The same applies to the shadows, as seen in the screenshot above.

[n-ovux]

This fork of picom doesn't have that issue https://github.com/Arian8j2/picom-jonaburg-fix it also adds some other nice features

[XPhyro]

This fork of picom doesn't have that issue

That fork comes with a different issue: it clips the window borders instead of wrapping them to the rounded corner.

[frebib]

Also notable the performance is a lot worse with the other implementations, which is particularly an issue when running on laptop iGPU where FPS is already barely 60fps

[BuddhiLW]

I'm using picom-ibhagwan-git, available on AUR. It works just fine. The performance is pretty good (I'm using a laptop with lower specs than you).

I'm using prime-run, so I run picom on my GPU (NVIDIA 1050 Ti card).

[BuddhiLW]

You can use https://github.com/ibhagwan/picom branch: next-rebase. Basically, it is the rounded-corner's problem fixed and rebased into yshui's picom.

Then, you just build as you would with ysui's and go on with the improvements of both branches.

May I add, you should also git pull and git fetch <yusui-repo> in ibhagwan(rebase-next), so you can profit from all other 100 and something commits done since the last rebase.

git pull
git fetch https://github.com/yshui/picom.git
# If you like the behavior you can merge
git merge

The downside on this methodology: you won't incorporate any further changes, unless you git fetch the repository again through this process etc.

[TomAintAround]

I have a similar problem, that doesn't involve with the blur, but with the shadows and border.

As you can see, the part that wasn't rounded isn't blurred, the problem is the shadows and border. How do I fix this?

[TomAintAround]

nevermind, i found an easy fix

[j-koziel]

I have the exact same issues....shadows and rounded borders just makes everything look weird with dual_kawase blur so I just decided to turn it all off

[s0nny7]

I'm using picom-ibhagwan-git, available on AUR. It works just fine. The performance is pretty good (I'm using a laptop with lower specs than you).

I'm using prime-run, so I run picom on my GPU (NVIDIA 1050 Ti card).

@BuddhiLW

Would you mind to share the driver you use? I encountered randomly staggering using ibhagwan's branch, I am using proprietary driver on my GTX 1060.

[PoSayDone]

is it going to be fixed? т_т

[BuddhiLW]

@s0nny7

$ lspci -k | grep -A 2 -E "(VGA|3D)"

lspci: Unable to load libkmod resources: error -2
00:02.0 VGA compatible controller: Intel Corporation CoffeeLake-H GT2 [UHD Graphics 630]
        DeviceName: Onboard - Video
        Subsystem: Dell Device 0949
--
01:00.0 VGA compatible controller: NVIDIA Corporation GP107M [GeForce GTX 1050 3 GB Max-Q] (rev a1)
        Subsystem: Dell Device 0949
        Kernel driver in use: nvidia

[nonetrix]

picom-ibhagwan-git

Well that fixes some of the issues and adds others like borders not working and shadows not being rounded :/

All of the picom forks seem to be out of date in someway

[BachoSeven]

@yshui Was this fixed by https://github.com/yshui/picom/pull/881?

[yshui]

@BachoSeven yep! thanks for reminding me! 🙂