prax icon indicating copy to clipboard operation
prax copied to clipboard

Published 20 hours ago • verified publisher icon ysbaddaden

Fix integration with Rack::File

Open packrat386 opened this issue 8 years ago • 4 comments

Changed intoduced to rack in the commit below broke the way that prax uses Rack::File. This change uses the new API.

https://github.com/rack/rack/commit/f244d4 https://github.com/rack/rack/commit/ed0d8c

packrat386 avatar Nov 03 '16 18:11 packrat386

Is it backward compatible?

ysbaddaden avatar Nov 17 '16 15:11 ysbaddaden

With old versions of Rack? Probably not, but given that this change was made to Rack over a year ago I think it's fair to say that in versions of prax moving forward we're only going to support Rack >= 2.0.0

packrat386 avatar Nov 17 '16 17:11 packrat386

The Ruby version of Prax is maintenance only (use the Crystal version). I'd like to avoid introducing a change for Rack 2+ that breaks compatibility with older versions of Rack.

We can't use Rack::VERSION but maybe use Rack::RELEASE to support both versions?

ysbaddaden avatar Nov 17 '16 18:11 ysbaddaden

@ysbaddaden how does the most recent version look?

packrat386 avatar Nov 17 '16 20:11 packrat386