irl-imitation icon indicating copy to clipboard operation
irl-imitation copied to clipboard

LPIRL: Redundant Constraints

Open aaronsnoswell opened this issue 7 years ago • 1 comments

Hi! Thank you for this great reference implementation - it is very helpful.

I was going over the LPIRL implementation and I think you have some redundant constraints in your LP matrices - see line 59 in lp_irl.py - this loop does the same thing as the previous loop on line 55, resulting in a redundant set of constraints.

Thanks again,

aaronsnoswell avatar Apr 04 '18 07:04 aaronsnoswell

@aaronsnoswell

Yeah. I too think the same way. In line 60, It should be -1.0 instead of 1.0. If I am correct, constraint in line 55 and line 59 should provide constraints that proxy l1 norm. Can you please check this @yrlu .

MithunNallana avatar Oct 28 '19 13:10 MithunNallana