Yves Reynhout

I imagine you'd want to derive from `NpgsqlTransaction`, decorating the original `NpgsqlTransaction` (the one returned from the connection or an ambient one), delegating all the work to it, but override...

This PR seems to duplicate parts of #317 IMO.

It's not really a workaround, TBH. It's opt-in - I don't see that option here.

One of the first things I spot here is that you're not using 1 instance of SqlStreamStore (which is preferred in the same process space). If the idea is to...

Sounds like a race ...

Are you using 1.2.x's ExpectedVersion with an older client (e.g. 1.1.x)? Or are you shipping the constant as part of another lib which you can't upgrade? What was the unexpected...

I've never really liked these as a constant nor as an integer - it should be opaque to the consumer and nobody should ever base decisions on the underlying value...

I agree this is a breaking change in that an existing value was (re)used for a different purpose and constants being copied and embedded into consumers can make this painful....

The general idea with acceptance tests is that they are applied across all providers (unless there's a compelling incentive not to). What exactly was the problem with reading a stream...

Sorry to keep this lingering - will review later today.