Yan Pujante
Yan Pujante
I agree it is a bit confusing. I renamed it per your suggestion.
> * Why is `emscripten_set_wheel_callback` called in the `ImGui_ImplGlfw_InstallEmscriptenCanvasResizeCallback()` function? > You asked me to fix the #7600 issue for the embedded path and the fix is to call `emscripten_set_wheel_callback`...
I made the change you requested `printf` -> `assert`. I made it as a `static_assert` because the runtime assert was pretty horrible from a user perspective At least with the...
After spending more time thinking about your proposed changes (add `ImGui_ImplGlfw_InstallEmscriptenCallbacks` and deprecate `ImGui_ImplGlfw_InstallEmscriptenCanvasResizeCallback`) I tried to implement it and I think I really like the suggestion. It makes it...
Hi @ocornut, I just found out an issue which is reproducible in BOTH the [old/embedded path](https://pongasoft.github.io/imgui/pr-7647/use_glfw3/) as well as the [new one](https://pongasoft.github.io/imgui/pr-7647/use_port_contrib_glfw3) on macOS * go to Demo/Inputs & Focus...
As I pointed out in my [comment](https://github.com/ocornut/imgui/issues/7732): * the issue exists with the built-in/embedded path * I have issued an [emscripten PR](https://github.com/emscripten-core/emscripten/pull/22141) to use the workaround [implemented for the new...
I merged all the changes (I saw there was a conflict which I fixed). I also rebuilt/republished the [demo](https://pongasoft.github.io/imgui/pr-7647/use_port_contrib_glfw3/) built with the latest emscripten (1.3.62) which contains the latest version...
As far as I know yes, this is mergeable. Due to the fact that you have to opt-in to use the new implementation, and the old implementation is still the...
> Topics/PR going over multiple things tends to be overwhelming/hard to process for me. Let me try to recap it for you and summarize it. This PR includes: 1. Introduced...
I sincerely apologize for that oversight. If you want me to address the problem I'm more than happy to look into it