yp05327

Results 309 comments of yp05327

I see. You added an option. It is acceptable. But the default value is `false` in code and `true` in app.sample.ini ![image](https://github.com/user-attachments/assets/43600b88-689e-4de9-ba31-9e54d973f9b7) ![image](https://github.com/user-attachments/assets/01db4f95-aade-4de4-bd63-6753f703336a)

> Is it safe to make AttachmentSrcToBase64DataURI read attachments directly? It means that it could read any attachment without permission check? If I remember correctly, there are some permission checks...

GitHub will disable the button when file is uploading. I didn't even notice this. Good issue. 😄

I found that the comment button here (in files changes tab) will not be checked (it will always be enabled), as what it does in conversation tab. ![image](https://github.com/user-attachments/assets/db7559dd-7c26-40a7-a99b-e9bd09632484) Do you...

It seems that this issue is similar to #30991? Maybe `OAUTH_USER` comes from here: https://github.com/git-ecosystem/git-credential-manager/blob/e124b8bb8f4a53301e0d9d947c075519f75ff222/src/shared/Core/GenericOAuthConfig.cs#L143

I found a related issue ( maybe ) in GCM: https://github.com/git-ecosystem/git-credential-manager/issues/1408 Maybe this is a problem from upstream (not directly related) ?

> Doesn't using a generator allow for async programming? Since 3.6, async generator is supported (according to ChatGPT). Actually, I'm using it, so it is possible. This is my code:...

> there is a high risk of 429 errors Why?

I think this is **partly** caused by git itself, because I have no idea why your `origin` remote is missing, for this, maybe you need to provide more information to...