nibe icon indicating copy to clipboard operation
nibe copied to clipboard

Update S-series registers, extensions, coil groups

Open vtamm opened this issue 7 months ago • 3 comments

Pull Request Type

Please select the type of your PR:

  • [x] Add/Update Registries
  • [x] Feature
  • [ ] Bug Fix

Description

Heatpump model: S1256 Firmware version: 4.2.4

  1. Added registers to s1156_s1256.csv and converted the updated CSV to JSON with the provided script
  2. Improved coil group configuration for S-series pumps (reasons here)
  3. Added mappings for valves and switches in S-series registers to extensions.json

Checklist

  • [x] I have followed the instructions
  • [x] I ensured that my changes are well tested

vtamm avatar May 23 '25 23:05 vtamm

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.34%. Comparing base (d900b70) to head (7598b62).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   70.19%   70.34%   +0.14%     
==========================================
  Files          14       14              
  Lines        1359     1359              
==========================================
+ Hits          954      956       +2     
+ Misses        405      403       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 24 '25 00:05 codecov[bot]

I am OK with these changes. @elupus, I am not very familiar with coil groups (I still use MQTT service instead of HA integration because of some dependencies). Does PR look fine for you? If yes, feel free to click merge.

yozik04 avatar May 24 '25 06:05 yozik04

Most things are linked to https://headless.nibe.eu/download/18.3bd9d98318c457ffd811678/1703680919076/M12676EN2.pdf

elupus avatar May 24 '25 06:05 elupus