logseq-banners-plugin icon indicating copy to clipboard operation
logseq-banners-plugin copied to clipboard

Specific banners for specific journal days

Open astubbs opened this issue 2 years ago • 15 comments

Is it possible to have a specific banner for a journal day? Or background?

I can get it to work for a page, but using the same code, putting it on a journal day, doesn't seem to do anything - I just see the default one.

astubbs avatar Jan 09 '23 13:01 astubbs

Yes you can. Just check the plugin's settings section. There are options for journal and common page respectively.

ireina7 avatar Jan 10 '23 01:01 ireina7

Yes I was looking at those - but the only show things around default banner, icons and sizes etc - nothing about enabling custom banners for journal pages. I tried adding banner:: to my journal day entry, and it didn't seem to do anything.

e.g.

banner:: https://images.hdqwalls.com/download/ryu-hadouken-street-fighter-2-55-2048x1152.jpg

But I just see the default banner image.

astubbs avatar Jan 10 '23 15:01 astubbs

Maybe you should update your plugin? My plugin logseq-banners-plugin setting section does have options for journal banner: image

ireina7 avatar Jan 11 '23 10:01 ireina7

I just installed in last week, when I discovered Logseq.

Yes, there is a section in the settings for journal and home settings.

But it only has a default banner setting. I'm not asking about settings a default banner for all journal pages, I'm asking about setting a specific banner, for a specific journal page. I.e. :

journals/2023_01_08.md:

banner:: https://images.hdqwalls.com/download/ryu-hadouken-street-fighter-2-55-2048x1152.jpg

- LATER Fix banner entry

But here's what I see - just the default banner.: Screenshot 2023-01-11 at 11 05 31 AM

On a logseq page, doing the same thing above, works as expected:

Screenshot 2023-01-11 at 11 06 06 AM

Here's my settings screenshot: Screenshot 2023-01-11 at 11 04 55 AM

I hope that clarifies the question?

astubbs avatar Jan 11 '23 11:01 astubbs

Thanks for your clarification. Now I understand your issue. You are right. I tried to set banner for specific journal page and the property just doesn't work.

ireina7 avatar Jan 11 '23 11:01 ireina7

Cool :) Next question - is this a bug, or a feature request? 🤗

astubbs avatar Jan 11 '23 12:01 astubbs

I'm not quite sure since I currently don't have much time to debug this. But I guess this is a feature request after checking some functions in src code. Maybe the rendering procedure uses the global config when rendering journal pages.

ireina7 avatar Jan 11 '23 16:01 ireina7

Ok cool. I might take a look at it this weekend - really want to get that street fighter themed day ;)

astubbs avatar Jan 12 '23 12:01 astubbs

Oh - @ireina7 given that I might try to take a look at it - any hints you might give as to where/ what it might be would be useful :)

astubbs avatar Jan 12 '23 21:01 astubbs

@astubbs Have you by any chance fixed the problem? I am trying to do the same thing, but for pages

HlexNC avatar Jan 24 '23 10:01 HlexNC

@HlexNC no, haven't looked into it yet and probably won't. But, banner image for a page works as expected for me. What problem with pages are you seeing? See my example above - "On a logseq page, doing the same thing above, works as expected:"

astubbs avatar Jan 24 '23 13:01 astubbs

@HlexNC no, haven't looked into it yet and probably won't. But, banner image for a page works as expected for me. What problem with pages are you seeing? See my example above - "On a logseq page, doing the same thing above, works as expected:"

No problem... just being dumb. I didn't see banner:: https:// in the README.md file.

HlexNC avatar Jan 25 '23 23:01 HlexNC

Works well 😆

HlexNC avatar Jan 25 '23 23:01 HlexNC

Guys, this is feature request. There is no handling a case for looking at the banner:: prop for journal pages in the source code.

stdword avatar Feb 15 '23 16:02 stdword

Any progress of this? Really need this feature, want to add "the picture of my day" to my journal's banner, to enhance my autobiographical memory.

blackwint3r avatar Apr 18 '23 08:04 blackwint3r