v-craft
v-craft copied to clipboard
yoychen
Vue 3 support
First, I want to say a big thank you for this library, its really awesome!
As the vue world has moved to v3, would it be possible to upgrade this library? Ive poked around, and tried to make it work, but im struggling :/
The main incompatibility is with the new slots system, and v-craft relies on slots heavily.
If someone can point me in the right direction, I could try to figure it out :)
I would also need someone to point me the right direction for this project with vue3. Thanks in advance
I would also need someone to point me the right direction for this project with vue3. Thanks in advance
I'm trying to make it works here https://github.com/loming/v-craft/tree/vue3, it's not fully working yet, but at least the text and properties are showing in the Example now
It works now in Vue3 :D
I would also need someone to point me the right direction for this project with vue3. Thanks in advance
I'm trying to make it works here https://github.com/loming/v-craft/tree/vue3, it's not fully working yet, but at least the text and properties are showing in the Example now
@yoychen Do you have plan to supports Vue3 with your great library? Or could I fork it out as a separate project?
@loming Of course, the current license of v-craft is MIT, so you can folk it as your need.
We are planning to recreate v-craft in Vue3 and make it more out-of-the-box and progressive. We wish the new v-craft will be a progressive page builder framework. It is not only a toolset for building your custom page builders. It will also provide an out-of-the-box page builder component with some default block elements like the v-craft sample, an interface for encapsulating your custom Vue components, and a plug system library for the ecosystem to create useful plugs.
great... I'm rewriting your current library in Typescript at the moment, I'll share it to u when it's ready and see if it helps you or not.
I don't have much time to help on redesigning the architecture though... i'm looking forward to your amazing work!
@loming
I've been testing on your vue3 branch with nuxt3 and typescript, and I think the naming of the Node class Node causes some issue during compilation.
https://github.com/loming/v-craft/blob/5fd3fccfca90fe0252721bffdcd33be18ada4c6c/src/core/Node.js#L1-L15
It might be related to SSR. The error is:
I haven't been able to trace down the root cause, but if I rename Node to something else, it works.
@loming I just tested the vue3 branch I am on the latest npm and node versions and updated all the npm modules. It now works a treat Looking forward to seeing this develop.
What a fantastic project you have here. I like your vision for the future. I have compared your project to the react project -> https://craft.js.org/examples/landing/. The react project is very well designed and I like the ability to edit the page and then be able to display it when finished. I also like the toolbars above the content being edited. It would be great if that could also be in the vue3 project. It would also be awesome if you could also have layers. And it would it be great if we were able to export the page as proper html and run it in the browser. Do you have an update on where you are with this project? I am very keen to help test it out. And once again keep up the amazing work.
@yoychen, @loming I have created a new repository based on your code for Vue3. My version has rewritten most of the code and includes a pinia store for easier statemanagement and integration.
The prototype is working, so far and some features/packages for GraphQL Integration will be also released soon. Have a look https://faasaf.gitlab.io/v-craft/main/ https://gitlab.com/faasaf/v-craft
@yoychen, @loming I have created a new repository based on your code for Vue3. My version has rewritten most of the code and includes a pinia store for easier statemanagement and integration.
The prototype is working, so far and some features/packages for GraphQL Integration will be also released soon. Have a look https://faasaf.gitlab.io/v-craft/main/ https://gitlab.com/faasaf/v-craft
Wow, it's awesome. Thanks for sharing 👍💪.
