Calling updates, allows not to set a new stickyBitStickyOffset value

[patric-eberle]

Describe the bug When calling this.stickybitInstance.update({ stickyBitStickyOffset: <my-new-value> }), the top spacing of the sticky element is not adjusted. It always seems to use the initial value, even though, the prop is updated on the instance.

To Reproduce

const stickybitsInstancetoBeUpdated = stickybits("selector");
stickybitsInstancetoBeUpdated.update({ stickyBitStickyOffset: 20 });

Expected behavior The sticky element uses the newly defined stickyBitStickyOffset as top value.

Screenshots

Desktop (please complete the following information):

• OS: macOS 10.15
• Browser: Chrome
• Version: 83

Additional context Stickybits: 3.7.7

I think the following ticket on the old repository documents the same issue, even if I was not able to call the recalculation from outside myself: https://github.com/dollarshaveclub/stickybits/issues/663

[sedax90]

We have the same problem... any ideas for solving?

[hanoii]

This seems to have done it for me:

    stickybitsInstance.update({ stickyBitStickyOffset: 20 });
    stickybitsInstance.update();

[gching]

So I've found an alternative way of updating it, by cleaning it up and it works for me:

stickyBitsInstance.cleanup();
stickyBitsInstance = stickybits('selector', {stickyBitStickyOffset: newOffset });

Of course your cleaning up the old instance and making a new instance of it but for now it works for my use-case.

[TwoD]

I think the main problem is that update does not actually have an effect or move the element directly. It would need to call the manageState() method with a force flag or similar to do all calculations checks again, and actually call applyStyles() even if the sticky/stuck state hasn't changed. There is no practical way to force that from the outside right now.