yowainwright
Split by Delimiters Passed To Shave Function
Proposed Changes
- Adds support to allow users to pass the delimiters they want to use. This will allow users to determine how the string should be broken up for the purpose of truncating text.
This pull request is for #411 that I made. This was how I fixed it for my project.
@CJames95 the demo you did was GREAT, and I'd love to get this feature in b/c it's a nice touch!!!
As it stands today, I'd like to make this feature so that the delimiter is drop-in replacement for ' '.
- no extra iteration (no more while loops) and
- no regex.
When this product was made, speed was key.
- My concern with the regex is stack overflow.
- My concern with the extra while loop is just a little less speed for customers who've been using shave for almost 10 years without the need for a delimiter.
Thank you! Happy to be enlightened on any ideas you have!
@yowainwright I am not sure I quite understand what you mean by
As it stands today, I'd like to make this feature so that the delimiter is drop-in replacement for
' '.
As far as you're concerns for Regex and any additional loops, that makes complete sense. This demo was a quick fix to a problem my team and I encountered and needed to solve.
Admittedly though, I'm not entirely sure how to accomplish this under the constraints at the moment, but I'll look into this more and see if I can come up with some alternatives.
@CJames95 I can look too! ...Might be a little bit but great work here! THANK YOU! I just want to ensure this nice feature doesn't affect other users. 🙌