vant icon indicating copy to clipboard operation
vant copied to clipboard

fix(Picker): should reset subsequent columns when a column is changed

Open JerryWu1234 opened this issue 10 months ago • 14 comments

… is changed somehow

fixes: #13365

add a new property for resetChildren


Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前,请阅读 贡献指南

JerryWu1234 avatar Feb 26 '25 06:02 JerryWu1234

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 89.75%. Comparing base (ec5b45b) to head (644808f). :warning: Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13366      +/-   ##
==========================================
+ Coverage   89.60%   89.75%   +0.14%     
==========================================
  Files         257      257              
  Lines        7013     7045      +32     
  Branches     1736     1744       +8     
==========================================
+ Hits         6284     6323      +39     
+ Misses        384      381       -3     
+ Partials      345      341       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Feb 26 '25 08:02 codecov-commenter

@inottn Please help to review. I done and fixed all fail tests .

JerryWu1234 avatar Feb 26 '25 08:02 JerryWu1234

I don't know if the previous interactions were intentional; if there is an issue, the onChange logic might need to be modified. If I have time, I will see how to adjust it.

inottn avatar Feb 27 '25 04:02 inottn

I don't know if the previous interactions were intentional; if there is an issue, the onChange logic might need to be modified. If I have time, I will see how to adjust it.

I definitely sure that it wasn't intentional. and it is a bug. I would like do it if you are busy.

JerryWu1234 avatar Feb 27 '25 05:02 JerryWu1234

thanks for point out. now no Area component error, and added edge case. please help to review it again @inottn

JerryWu1234 avatar Mar 01 '25 13:03 JerryWu1234

I prefer to keep the current behavior. If we reset the option it will break the user experience of date picker or time picker.

chenjiahan avatar Mar 02 '25 07:03 chenjiahan

I prefer to keep the current behavior. If we reset the option it will break the user experience of date picker or time picker.

ok, if we keep the current behavior. Is there another workaround to fix it? @chenjiahan

JerryWu1234 avatar Mar 02 '25 07:03 JerryWu1234

How about adding a new prop to enable this new behavior? Such as resetChildren.

chenjiahan avatar Mar 09 '25 12:03 chenjiahan

How about adding a new prop to enable this new behavior? Such as resetChildren.

I think the default should be false if we add a new prop.

JerryWu1234 avatar Mar 09 '25 14:03 JerryWu1234

@chenjiahan @inottn I done.

JerryWu1234 avatar Mar 13 '25 09:03 JerryWu1234

@inottn please help to review. because my production needs this feature , thanks

JerryWu1234 avatar Mar 20 '25 07:03 JerryWu1234

@inottn please help to review. because my production needs this feature , thanks

Sorry for the delay. Vant is currently community-driven, and PR reviews might not be prompt, I've been very busy lately, and I apologize again. If needed, you can temporarily resolve issues using methods like pnpm patch.

inottn avatar Mar 29 '25 06:03 inottn

@inottn please help to review. because my production needs this feature , thanks

Sorry for the delay. Vant is currently community-driven, and PR reviews might not be prompt, I've been very busy lately, and I apologize again. If needed, you can temporarily resolve issues using methods like pnpm patch.

Please don't forget my PR

JerryWu1234 avatar May 22 '25 11:05 JerryWu1234

@inottn please help to review. because my production needs this feature , thanks

Sorry for the delay. Vant is currently community-driven, and PR reviews might not be prompt, I've been very busy lately, and I apologize again. If needed, you can temporarily resolve issues using methods like pnpm patch.

Please don't forget my PR

@JerryWu1234 You have been forgotten ....

lllomh avatar Sep 17 '25 09:09 lllomh