vant icon indicating copy to clipboard operation
vant copied to clipboard

fix(tabBarItem): issues:TabbarItem component in the route mode fails …

Open lzxiaoqi opened this issue 1 year ago • 5 comments

…to bind with v-model

Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前,请阅读 贡献指南

修复issues中提到的Tabbar组件在路由模式下访问TabbarItem导致v-model未同步修改的问题 TabbarItem component in the route mode fails to bind with v-model bug

lzxiaoqi avatar Oct 28 '24 04:10 lzxiaoqi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.61%. Comparing base (379f44a) to head (a2f9cdf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13177      +/-   ##
==========================================
- Coverage   89.67%   89.61%   -0.07%     
==========================================
  Files         257      257              
  Lines        7004     7008       +4     
  Branches     1732     1733       +1     
==========================================
- Hits         6281     6280       -1     
- Misses        378      384       +6     
+ Partials      345      344       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 28 '24 04:10 codecov-commenter

https://github.com/youzan/vant/issues/13172

lzxiaoqi avatar Oct 28 '24 04:10 lzxiaoqi

Thanks for your PR. Can you add a test case for this issue?

inottn avatar Oct 30 '24 04:10 inottn

Thanks for your PR. Can you add a test case for this issue?感谢您的 Pull Request。能否为这个问题添加一个测试用例?

您好 测试用例已经添加 看是否ok的

lzxiaoqi avatar Oct 30 '24 07:10 lzxiaoqi

这个晚些时候想一下有没有更好的解决办法 看样子是优化代码解决计算属性中的副作用之后涉及到路由的单元测试存在点问题

lzxiaoqi avatar Nov 02 '24 04:11 lzxiaoqi