cobalt
cobalt copied to clipboard
Add xb1_test builders
b/323410310
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.04%. Comparing base (
fd65e24
) to head (ffb74ae
). Report is 1346 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
- Coverage 59.30% 59.04% -0.26%
==========================================
Files 1712 1744 +32
Lines 78577 80006 +1429
==========================================
+ Hits 46598 47239 +641
- Misses 31979 32767 +788
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm not familiar with workflow files so this might be a dumb question, but would the tests be run against the github devel build or the internal build from copybara?
If it's off the github build, we'll have to review all the tests to verify they pass as expected. We should also verify that the app is packaged in the expected way (for instance in our packager script we use the app name youtube for internal builds and cobalt for external builds).
I'm not familiar with workflow files so this might be a dumb question, but would the tests be run against the github devel build or the internal build from copybara?
If it's off the github build, we'll have to review all the tests to verify they pass as expected. We should also verify that the app is packaged in the expected way (for instance in our packager script we use the app name youtube for internal builds and cobalt for external builds).
i think its of github build - @oxve to verify. Yes we'll need to verify as you mentioned. Will address this after a test can be triggered
closing here, reopening as a proper feature branch: https://github.com/youtube/cobalt/pull/2438