Please remove binary file test_project/db.sqlite

[nirgal]

Hello

You project distribute with binary file test_project/db.sqlite, which makes it difficult to distribute. That file should be removed from your project. I believe it can be generated using ./manage.py syncdb --noinput. So unit tests needs to be changed to do that first.

[jpic]

So we can't ship an example database anymore ?

[nirgal]

Hi.

As you may remember I about to introduce django-session-security in Debian: https://ftp-master.debian.org/new/django-session-security_2.2.3-1.html then when/if it's accepted by ftp-masters: https://packages.qa.debian.org/d/django-session-security.html

Debian is really picky about source and binaries, and I might have to remove that file from your tarballs before distribution. It's no big deal, that happens. However, in that case, I have the impression the binary is not needed, because you already have a script to generate it: "./manage.py syncdb --noinput" I you don't do it, I'll try to find a way to have your tests run without the blob, and come back with a patch for that.

In my humble opinion, if you can have either the binary or the script to build it, you should go for the human readable version.

I'll keep you posted.

[jpic]

It will work if we remove it but it'll be a bit less convenient for developers, since we'll have to syncdb and createsuperuser when we setup the test_project for local use.

That said I'd expect Django to create an sqlite database in memory when it runs tests, so db.sqlite should not be required to run ./manage.py test session_security.