LEClient icon indicating copy to clipboard operation
LEClient copied to clipboard

Published 20 hours ago • verified publisher icon yourivw

Exception Classes are not PHP5 compatible

Open damanic opened this issue 3 years ago • 2 comments

Class constant visibility is only allowed since PHP 7.1

Example in LEConnectorException

	public const NONEWNONCEEXCEPTION 			= 0x11;
	public const ACCOUNTDEACTIVATEDEXCEPTION 	= 0x12;
	public const METHODNOTSUPPORTEDEXCEPTION 	= 0x13;
	public const CURLERROREXCEPTION 			= 0x14;
	public const INVALIDRESPONSEEXCEPTION 		= 0x15;

damanic avatar Feb 24 '22 04:02 damanic

Considering that PHP8 is current, I doubt anyone will have time to maintain support for PHP5.

TheRealSimpleSimon avatar May 02 '22 05:05 TheRealSimpleSimon

@TheRealSimpleSimon Considering the guidance on your repo states The minimum required PHP version is 5.2.0. , the pull request is valid.

Did anyone actually need to introduce constant visibility? If you are keeping the change you need to update your minimum required PHP version to 7.1

damanic avatar May 02 '22 06:05 damanic