webannoyances icon indicating copy to clipboard operation
webannoyances copied to clipboard

sublists

Open KonoromiHimaries opened this issue 6 years ago • 16 comments

do you can divide the webannoyances list into a sublists

example. you can based on the model of polishsubfilters https://github.com/KonoromiHimaries/PolishSubFilters/tree/master/internal-filters or polishannoyancefilters model https://github.com/PolishFiltersTeam/PolishAnnoyanceFilters/tree/master/PPB

potential benefits

  • fast loading of the list
  • increased editing convenience
  • anyone will be able to subscribe to one sublist without having to subscribe to all webannoyances filters

KonoromiHimaries avatar Jun 03 '18 16:06 KonoromiHimaries

I would ultimately like to do this but need to research how some of the other lists maintainers manage this before doing so.

It's also a time commitment that I don't have right now to implement immediately.

yourduskquibbles avatar Jun 04 '18 15:06 yourduskquibbles

You can just divide it into few files, then use #include directives in big main filterlist, which uBO supports to include smaller lists. Of course you can also do that just like I created templates file, made some scripts to merge all, but I think that in that case it's not needed, cuz you support only uBO, but maybe autosorting and autoversioning will be useful :smile:

hawkeye116477 avatar Jul 16 '18 14:07 hawkeye116477

Forgot this was still open, thanks for closing @KonoromiHimaries

yourduskquibbles avatar Jan 21 '19 19:01 yourduskquibbles

Moving forward, I will be moving empty advertising filters into the ad_placeholders.txt sublist.

The long-term intention with ad_placeholders.txt sublist will be to remove all of these advertising filters from utlralist.txt so eventually ultralist.txt is ONLY a list that exists to subscribe to all Web Annoyances sublists.

This should allow the flexibility for users to only subscribe to certain features of Web Annoyances Ultralist e.g. users who only want to remove social buttons & empty ad boxes but don't want to change any CSS elements of a site like sticky headers or newsletter subscription requests (e.g. don't subscribe to css_style_filters.txt & newsletter_filters.txt)

This is also the reason behind recently creating css_companion_filters.txt sublist.

yourduskquibbles avatar Dec 06 '19 16:12 yourduskquibbles

Reopening to help others track maintenance progress of moving existing filters from ultralist.txt into various sublists.

yourduskquibbles avatar Dec 06 '19 16:12 yourduskquibbles

It might make sense to give cookie/gdpr filters their own sublist.

Also, I see a bunch of social filters in the generic sublist.

I'd be happy to submit a pull request for one or both of these if you're interested.

RedDragonWebDesign avatar Jun 23 '20 20:06 RedDragonWebDesign

Should paywall filters go in a separate list too? And what's the policy in this repo? Are all paywalls removed when possible?

liamengland1 avatar Jun 23 '20 20:06 liamengland1

@GeneralKenobi1 I agree with splitting up cookie/gdpr filters - I can create a new sublist for that and I would be happy to accept a PR - Right now most of those filters would be in the modal_filters.txt list as well as generic_filters.txt

@llacb47 I prefer not to have a separate paywall sublist, the general policy for Web Annoyances Ultralist is to remove them if it's a soft paywall/warning that only requires modifying CSS or blocking a 1st or 3rd party script - no script injection workarounds or faking subscription status.

There are separate extensions users can use if they want to go that route, e.g. Bypass Paywalls Clean for Firefox & Bypass Paywalls Clean for Chrome or even something as simple as Cookie Auto Delete for Firefox & Cookie Auto Delete for Chrome

yourduskquibbles avatar Jun 24 '20 13:06 yourduskquibbles

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L186

liamengland1 avatar Jun 24 '20 13:06 liamengland1

@GeneralKenobi1 I just added a new cookie_filters.txt sublist and just seeded it with a few existing filters from the modal_filters.txt sublist. Feel free to submit PR's and THANK YOU in advance for any help!

yourduskquibbles avatar Jun 24 '20 13:06 yourduskquibbles

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

yourduskquibbles avatar Jun 24 '20 13:06 yourduskquibbles

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

https://github.com/yourduskquibbles/webannoyances/blob/8a0a299bab3ea67a533506811d42b938575807c1/ultralist.txt#L186

I'm not saying you should remove it by the way, just saying this policy limits how much paywall bypassing can be done

liamengland1 avatar Jun 24 '20 13:06 liamengland1

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

https://github.com/yourduskquibbles/webannoyances/blob/8a0a299bab3ea67a533506811d42b938575807c1/ultralist.txt#L186

I see you pointed to L186 in edit now, yes I will remove that, no need to create undue risk when other extensions exist. Probably added it a long time ago when I found the filter on reddit or something like that. Thanks for pointing out

yourduskquibbles avatar Jun 24 '20 13:06 yourduskquibbles

I'm not saying you should remove it by the way, just saying this policy limits how much paywall bypassing can be done

It's OK, it's not the intention or primary goal of this list to bypass paywalls so don't want to host that anyway and risk taking the whole project down.

yourduskquibbles avatar Jun 24 '20 13:06 yourduskquibbles