tsrc icon indicating copy to clipboard operation
tsrc copied to clipboard

Add feature to optionally checkout configured branches on sync, when …

Open gdubicki opened this issue 2 years ago • 2 comments

Partially implements #286

gdubicki avatar Oct 01 '22 11:10 gdubicki

I find it weird that this is an option in the manifest ... I was expecting an other tsrc sub-command or a flag in tsrc sync

dmerejkowsky avatar Oct 10 '22 09:10 dmerejkowsky

I find it weird that this is an option in the manifest ... I was expecting an other tsrc sub-command or a flag in tsrc sync

You are right. If this is in manifest then it's forced on all of its users, while a sub-command or a flag makes it a user's choice.

I propose to switch this to a flag like tsrc sync [-c/--correct-branch]. Ok, @dmerejkowsky?

gdubicki avatar Oct 14 '22 19:10 gdubicki

I propose to switch this to a flag like tsrc sync [-c/--correct-branch]. Ok, @dmerejkowsky?

Sounds good. Go for it :)

dmerejkowsky avatar Oct 20 '22 08:10 dmerejkowsky

I propose to switch this to a flag like tsrc sync [-c/--correct-branch]. Ok, @dmerejkowsky?

Sounds good. Go for it :)

Done. Can you please review?

gdubicki avatar Oct 21 '22 16:10 gdubicki

A gentle nudge, @dmerejkowsky ;)

gdubicki avatar Oct 27 '22 20:10 gdubicki

Looks good to me - let's merge this :)

dmerejkowsky avatar Oct 28 '22 17:10 dmerejkowsky

@gdubicki I think it would be nice to make sure you can publish tsrc releases on your own. Feel free to contact me so we can figure out the details.

dmerejkowsky avatar Oct 28 '22 17:10 dmerejkowsky