Yang Xiufeng

Results 90 comments of Yang Xiufeng

@Xuanwo forgot to change to Draft when fixing failed tests. rebased just to merge a small fix commit to earlier commit, no big change.

flaky test test_alter_recluster_interpreter https://github.com/datafuselabs/databend/actions/runs/3112438121/jobs/5045863994 cc @zhyass

I think we should not do manual escape here, the SQL should remain unchanged after the JSON encode(client)/decode(server), need to examine why we are relying on this escape now.

it`s a known issue, https://github.com/datafuselabs/databend/issues/6262 I thought it happens in limited special cases, and is not blocking any other thing, so not fixed yet. need to 1. return error like...

fixed by https://github.com/datafuselabs/databend/pull/7019

@BohuTANG after discussing with @flaneur2020, I think we may change password_type back to auth_type. and use the same field to hold enum { JTW, Sha256Password, DoubleSha1Password, ...}, which directly corresponds...

better way for rust is to use enum? enum { Password(type PasswordType,password vec) Ldap(config string) }

ok, I will do it