youngcw

Results 197 comments of youngcw

Nice. This seems to be working as I would expect now. My only gripe now is that I keep putting in positive values expecting them to be payments in transaction....

> Just to confirm, were you thinking to change _all_ rule amount inputs to use the schedule picker? That would be nice, but that might be for a different PR...

Do you have a sanitized file or an example budget to test the import? Code looks pretty good

ok, that worked as far as I can tell. Is that the full budget?

As long as its a good representation of a full budget its fine. If you fix those missing tests I can look at approving this

> I think it's de-dup what's causing the headache Are you adding two transactions for a transfer? One regular transaction, then a transfer transaction? That could maybe be part of...

@jsehnoutka if you are wanting to take over I would start with getting the github tests passing. There are a few concerns voiced in the comments that I believe still...

I agree that it would be nice to not show the blue lines on places that the transaction cant be dropped. Im not sure if a visual indicator is needed...

@joel-jeremy What is left on this?

> There is also the possibility that people just hide cateegories to 'de-clutter' the budget page vs using it to deprecate categories. I think I would categorize this as bad...