MediaBrowser icon indicating copy to clipboard operation
MediaBrowser copied to clipboard

Published 20 hours ago • verified publisher icon younatics

Errors with SDWebImage 5.0.x

Open TomMajor opened this issue 5 years ago • 7 comments

Using MediaBrowser in a recent project lead to 2 errors in the MediaBrowser Pod which makes further compile in the project impossible. The 2 errors are at:

Media.swift #194 operation = SDWebImageManager.shared().loadImage(... Cannot call value of non-function type 'SDWebImageManager'

MediaBrowser.swift #307 SDImageCache.shared().clearMemory() Cannot call value of non-function type 'SDImageCache'

Because latest MediaBrowser release was on March 31 and SDWebImage made a major release 5.0 on April 2, I thought to give it a try with the SDWebImage version which was current when MediaBrowser 2.3.0 was reelased. So I fixed this error with explicitly stating in the podfile to use version 4.4.6 of SDWebImage.

Would be great if this could be fixed for next release of MediaBrowser so that current SDWebImage can be used.

Thanks,

TomMajor avatar May 22 '19 15:05 TomMajor

+1

ro8i avatar Jun 25 '19 22:06 ro8i

+1

matheusfalcao20 avatar Jun 30 '19 04:06 matheusfalcao20

+1

Milap-Kundalia avatar Oct 15 '19 09:10 Milap-Kundalia

How did you specify to use 4.4.6. I have tried and am getting

Value of type 'SDWebImageManager' has no member 'loadImage'

f15radar avatar Dec 29 '19 04:12 f15radar

There is a special syntax in the podfile for locking the pod to a specific version, you have to read the docs for that - I don't have my Macbook at hand. This project seems kind of dead anyway :crying_cat_face: , maybe one would better look for another media browser library?

TomMajor avatar Dec 29 '19 23:12 TomMajor

I can handle PR or collaborator:). The work is so busy that I can't care about open source. Please request me anyway!

younatics avatar Jan 02 '20 02:01 younatics

@younatics I just dicovered that this PR from @atulkhatri will fix this issue I raised about 1 year ago: https://github.com/younatics/MediaBrowser/pull/83

Could you please consider to merge this and release a new version with it, so Cocoapods will pull this fix?

Also I discovered another small issue (maybe because of new iPhone screen sizes?), please see attached screenshot. There is a small white stripe on top below the status bar, this white was the previous view, presenting the browser does not cover the full screen anymore. Could you please hint the place in code where this view size is set, so see if I can do anything about it? Thanks, ScreenShot 41

TomMajor avatar Jun 30 '20 23:06 TomMajor