MediaBrowser icon indicating copy to clipboard operation
MediaBrowser copied to clipboard

Mixed videos/images navigation issues

Open weakfl opened this issue 6 years ago • 5 comments

If videos and images are used together the UIPageViewController navigation has issues (see attached video). To reproduce the issue just add an image to the "Web videos" demo.

Also it would be nice if the corresponding thumb would be displayed beneath the play button instead of the error image.

mixed_video_images.mp4.zip

weakfl avatar Nov 13 '17 16:11 weakfl

I invited you as collaborator of this library. If you are not mind, we can make this library together :)

younatics avatar Nov 14 '17 08:11 younatics

@younatics Thanks! I'm pretty busy with other projects, but I'll try to help whenever I can. I'm planning to integrate the library into an app with a couple of hundred thousand users per month, so it'll be in my own interest to iron out bugs and improve the lib...

weakfl avatar Nov 14 '17 10:11 weakfl

you can accept my invite, and I will help you with my best. Thanks!

younatics avatar Nov 14 '17 10:11 younatics

@younatics I've added a previewImageURL parameter to the initializer and updated the demo:

public convenience init(videoURL: URL, previewImageURL: URL? = nil) {
    self.init()

    self.videoURL = videoURL
    isVideo = true
    emptyImage = (previewImageURL == nil) ? true : false
    self.photoURL = previewImageURL
}

Please take a look at the corresponding branch.

However, I haven't figured out what is causing the scrolling issue yet. Maybe you could take a look and see if you can fix it?

weakfl avatar Nov 21 '17 15:11 weakfl

@weakfl I updated your commit and I will check how to fix it ASAP...

younatics avatar Nov 26 '17 02:11 younatics