Riad Benguella

Results 439 comments of Riad Benguella

Great. Thanks for the confirmation. In that case, I think we should move the code here https://github.com/WordPress/gutenberg/pull/62304#discussion_r1627866620 directly to the "editor" package somehow. edit-post and edit-site shouldn't have to pass...

I looked at this earlier today, and it's good to ship to me as well. I think tests are somewhat stable these days, so if restart (or rebasing) doesn't really...

All good for me, I think there's probably a remaining failure on the performance tests it seems. the subtlety for the performance test is that the same test should be...

Would love to see this PR move forward and land. @fabiankaegy Is that something you can help with? How can I help personally?

Based on the screenshots in the performance test failures, it seems like the the performance tests are expecting the page to be in "template-locked" (access the post content block) but...

For the mobile unit tests, what's happening is that `getPostType` calls don't return anything at the moment in the unit test, so the editor doesn't initialize (doesn't render the block...

@dcalhoun As you can see here, we have this code in the editor provider ``` const postTypeObject = select( coreStore ).getPostType( post.type ); ``` This code performs a REST API...

In case it helps, There's this condition ``` if ( ! isReady || ! mode || ! hasLoadedPostObject ) { ``` This condition means that we don't render anything if...

This seems ready to go, If I'm not wrong the main impact of this PR is that pages are going to show templates in the post editor by default as...

> When we'll choose to edit an item, should it load the post or the site editor? I've started by having as a goal to load the site editor. This...