Jeong, YunWon

Results 849 comments of Jeong, YunWon

As same as its package name 2025년 11월 14일 (금) 18:19, Shahar Naveh ***@***.***>님이 작성: > *ShaharNaveh* left a comment (RustPython/RustPython#6214) > > > @youknowone @coolreader18 > how should we...

test_syntax is broken

It's been so long time ago I worked on slots. I forgot the most of details. CPython basically inherits slots not to require subtypes to crawl up the entire mro....

@ShaharNaveh Could you please be a primary reviewer of this patch?

beacuse MRO is currently not weakrefs, this prevent RC=0 to release type objects

@YashSuthar983 Make a commit from CI. We already have `cargo fmt --check`, and the solution is usually running `cargo fmt --all` and commit the changes. It can be trivially autumated.

I didn't try that yet, but some github actions look like supporting it. - https://github.com/marketplace/actions/add-commit - https://github.com/marketplace/actions/git-auto-commit - https://github.com/marketplace/actions/add-commit-and-push Not sure which one is best fit for this purpose though....

@YashSuthar983 I checked the repository and it is looking great! Could you apply the same workflow to RustPython too?

I expected auto-format before all other workflow, but auto-format at end of workflow also sounds reasonable. manual triggering is not a desired one. (better than no auto-format though)