apple-sys icon indicating copy to clipboard operation
apple-sys copied to clipboard

Upgrade bindgen

Open youknowone opened this issue 4 months ago • 1 comments

Summary by CodeRabbit

  • Chores
    • Upgraded a build-time codegen dependency to a newer patch release to stay current; no user-facing behavior changes.
    • Updated CI matrix for macOS/iOS: disabled fail-fast for macOS, removed several platform targets, and commented/disabled a few platform-specific checks to streamline CI runs.

youknowone avatar Sep 08 '25 05:09 youknowone

Walkthrough

Updated the bindgen dependency in bindgen/Cargo.toml from "0.69" to "0.72.1" and adjusted the GitHub Actions CI matrix in .github/workflows/rust.yml by setting fail-fast: false for the sys-macos strategy and removing/commenting several matrix entries (including AuthenticationServices and others). No public APIs changed.

Changes

Cohort / File(s) Summary
Dependency bump
bindgen/Cargo.toml
Bumped bindgen dependency from "0.69" to "0.72.1".
CI workflow adjustments
.github/workflows/rust.yml
Set fail-fast: false for sys-macos; removed IMServicePlugIn, JavaNativeFoundation, and ExposureNotification from matrices; commented-out/disabled AuthenticationServices, BusinessChat, and AddressBookUI entries in sys-macos/sys-ios.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer (push/PR)
    participant GH as GitHub Actions
    participant Matrix as Job Matrix
    participant macOS as sys-macos jobs
    participant iOS as sys-ios jobs
    Dev->>GH: push PR
    GH->>Matrix: expand matrices (updated)
    Note right of Matrix: bindgen bump is in repo\nCI matrix entries removed/commented
    Matrix->>macOS: run macOS jobs (fail-fast: false)
    Matrix->>iOS: run iOS jobs
    macOS-->>GH: job results (no early cancel)
    iOS-->>GH: job results
    GH-->>Dev: aggregate results

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Upgrade bindgen" succinctly and accurately describes the primary change in this PR—the bindgen dependency bump in bindgen/Cargo.toml (0.69 → 0.72.1); although the PR also contains GitHub Actions workflow tweaks, the title clearly communicates the main intent and is concise for reviewers scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I nibble versions, soft and bright,
A crate hops up into the light.
CI pruned branches, jobs run free,
Mac and iOS hum along with me.
Small changes, big thumps — a happy rabbit's night. 🐇✨

[!TIP]

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25f6a0e39f2fa886d789d1929e0b18e4a97c6ce4 and 693e77bb8c9984bd2dc843860f3764221031fa33.

📒 Files selected for processing (1)
  • .github/workflows/rust.yml (2 hunks)
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch upgrade-bindgen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 08 '25 05:09 coderabbitai[bot]