yknytt icon indicating copy to clipboard operation
yknytt copied to clipboard

Wrong sound for horizontal bars

Open fabzenfab opened this issue 1 year ago • 15 comments

Hi guys,

I would like to report a problem, an issue : all sounds correspond to the original except :

the sound of horizontal bars with peaks going up and down (the current noise is horrible lol, sorry, it sounds like a gunshot against a metal plate)... sorry again

the sound of the double jump is wrong too. It's not very important to me but if you could change it that would be great ;-)

I'm not a programmer and I don't know if all of this is possible but if you could take my request into account I would be infinitely grateful :-D Love

millions of thanks for the work accomplished because I wear glasses and FPS are really welcome for comfort and visual fatigue THANK YOU !

fabzen

fabzenfab avatar Nov 08 '23 16:11 fabzenfab

Implementing double jump sound has been denied in #179 despite there being a patch for it - #195. Hopefully there will be a release soon (with this patch already committed) at a fork of this project: https://github.com/jakerosado/KnyttStories but compiling the code yourself isn't that hard - given your enthusiasm you should try it.

ms2048 avatar Nov 08 '23 19:11 ms2048

all sounds correspond to the original except

Actually, the lock sound doesn't correspond either, and there might be others. I'll test all objects at some point, and report all the wrong sounds

Lt-knb avatar Nov 09 '23 03:11 Lt-knb

Thank you Lt-knb, that's nice of you

ms2048, no need to be cynical, I told you that I know nothing about computers,... my comment was just feedback

Regarding the positive side of things, I find the yknytt project amazing and my enthusiasm for knytt stories - which I consider to be the best game of recent years - is intact ;-)

Have a nice day

fabzenfab avatar Nov 15 '23 15:11 fabzenfab

ms2048, no need to be cynical, I told you that I know nothing about computers,... my comment was just feedback

my comment was just information + advice

ms2048 avatar Nov 15 '23 22:11 ms2048

ok ok no prob ;-)

fabzenfab avatar Nov 18 '23 11:11 fabzenfab

Implementing double jump sound has been denied in #179 despite there being a patch for it - #195. Hopefully there will be a release soon (with this patch already committed) at a fork of this project: https://github.com/jakerosado/KnyttStories but compiling the code yourself isn't that hard - given your enthusiasm you should try it.

Poor timing on my part; I'm a full-time grad student and software engineer. End-of-year crunch at both work and school is real. I will put a release out with my previous fixes and a patch for this particular sound this weekend.

all sounds correspond to the original except

That's not true. The lock sound doesn't correspond either, and there might be others. I'll test all objects at some point, and report all the wrong sounds

Please do. Feel free to open issues and discussions over on my fork. The notifications will help remind me to put effort towards this where needed.

jakerosado avatar Nov 28 '23 21:11 jakerosado

thank you that's nice of you ;-)

fabzenfab avatar Dec 01 '23 10:12 fabzenfab

I'll be back in a few weeks while I'm finishing out my semester. Couple fixes for now: https://github.com/jakerosado/KnyttStories/releases

@fabzenfab @ms2048 @Lt-knb @blipdrifter @djsolidsnake86

jakerosado avatar Dec 03 '23 04:12 jakerosado

awesome ! Thank you very much :-D

fabzenfab avatar Dec 28 '23 16:12 fabzenfab

Hello jakerosado ;-)

Thank you for the job you did. Just to let you know... 2 few issues but nothing really important : 1 ) On windows 10, when you close the program, you have a white screen. To end properly you need to come back to the desktop and close the application 2) The icon of the application is not the one of KS but the logo of Gogot game engine All the rest is perfect ;-) 3) this program is great because you can play KS with a joypad :-D but when you are in the map you have to go back to the mouse, it will be nice to navigate in the map also with the joypad... but it's a detail Thanks, have a nice day fabiche

fabzenfab avatar Jan 10 '24 13:01 fabzenfab

Hey @fabzenfab,

I'll look into it. Just to note something: I don't want to add too many new features to YKnytt. I stopped working on a source port in KS after coming across this project a couple years ago. I am gradually picking it back up again because, while I admire the work done on this project, I'd like to make a more accurate source port of the original. From there, I'd branch and build off of that. Hope to get your guy's support with that.

jakerosado avatar Jan 10 '24 21:01 jakerosado

Hello jakerosado, I understand and I'm already delighted with what you've done. Also great is the idea of ​​wanting to get as close as possible to the original. I can see that you are a fan too ! I don't know if you noticed but the recent levels are more and more worked. Imagination has no limits I don't know computers, I don't realize the work required for a program like this one. So take your time, I will follow your project with great interest ;-) With patience and confidence in talent and in the future :-D Thank you

fabzenfab avatar Jan 11 '24 13:01 fabzenfab

First of all, I didn't deny this pull request. jakerosado closed it by himself in a few days, when I was absent. Then started his fork without any questions. Don't think it's a common practice. Second, I wonder why Lt-knb decided that many sounds are wrong. Three is not many. I checked all the sounds in 2022, and 95% that other sounds are correct. I will stay away from this topic as much as possible. Looks very suspicious to me.

up-left avatar Mar 27 '24 15:03 up-left

Hey, @up-left, thanks for chiming in. I'd like to apologize; it was preemptive of me to fork the project solely based on one comment:

tbh I just used to playing without double jump sound. so I have no plans to add it.

One of the common problems pointed out in UX is how often those doing the coding will override the feedback of others in favor of their own opinions, rather than crafting the software in conjunction with one another. However, given what you've stated, I seem to have misinterpreted your intent and am sorry about that.

jakerosado avatar Mar 27 '24 16:03 jakerosado

he had no bad intentions, it was to please me I imagine. the idea, in all areas, is to move forward together I don't know how to program but I'm very happy when the project progresses, thank you both :-D

fabzenfab avatar Mar 28 '24 11:03 fabzenfab